client/samples/dartcombat/views.dart - Issue 8467034: Isolates in frog - tweaks in existing js code to make things run

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: client/samples/dartcombat/views.dart

Issue 8467034: Isolates in frog - tweaks in existing js code to make things run (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: '' Created 9 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: client/samples/dartcombat/views.dart

diff --git a/client/samples/dartcombat/views.dart b/client/samples/dartcombat/views.dart

index 9d96166bb0d74001b04b74b93557724c4f24d125..3b411e24d3a0eba2536a0d5b0d52deac34dea806 100644

--- a/client/samples/dartcombat/views.dart

+++ b/client/samples/dartcombat/views.dart

@@ -282,7 +282,7 @@ class ViewUtil {

gridNode.rect.then((ElementRect rect) {

int x = (e.pageX - rect.offset.left) ~/ 50;

int y = (e.pageY - rect.offset.top) ~/ 50;

- completer.complete(const [x, y]);

+ completer.complete([x, y]);

jimhug 2011/11/08 15:39:01 Why did you lose the const here?

Siggi Cherem (dart-lang) 2011/11/08 17:56:42 Basically x, y are variables, which are not allowe

});

return completer.future;

}

« no previous file with comments | « client/samples/dartcombat/grids.dart ('k') | frog/frogsh » ('j') | frog/frogsh » ('J')