Isolates in frog - tweaks in existing js code to make things run

client/samples/dartcombat/views.dart

 // Copyright (c) 2011, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 /** Base class for all views. */
 class View {
   Document doc;
   View(this.doc) {}
 }
 
@@ skipping 264 matching lines @@
 
 /** Utility methods used by the views above. */
 class ViewUtil {
 
   /** Extract the position of a mouse event in a containing 500x500 grid. */
   static Future<List<int>> positionFromEvent(Element gridNode, MouseEvent e) {
     final completer = new Completer<List<int>>();
     gridNode.rect.then((ElementRect rect) {
       int x = (e.pageX - rect.offset.left) ~/ 50;
       int y = (e.pageY - rect.offset.top) ~/ 50;
-      completer.complete(const [x, y]);
+      completer.complete([x, y]);

[jimhug, 2011/11/08 15:39:01]

Why did you lose the const here?

[Siggi Cherem (dart-lang), 2011/11/08 17:56:42]

Basically x, y are variables, which are not allowed to be used within const
expressions. We actually want here an immutable array (rather than a const).

     });
     return completer.future;
   }
 
   /** Given a grid node (square or boat) place it at a grid coordinate. */
   static void placeNodeAt(Element node, int x, int y) {
     int xoffset = x * 50;
     int yoffset = y * 50;
     node.style.setProperty("top", yoffset.toString() + "px");
     node.style.setProperty("left", xoffset.toString() + "px");
   }
 
   /** Create a div node with a given class name. */
   static Element createDiv(View view, String className) {
     Element node = view.doc.createElement("div");
     node.attributes["class"] = className;
     return node;
   }
 }