Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Side by Side Diff: src/incremental-marking.cc

Issue 8467014: Revert accidental commit that messed up the incremental speed heuristics. (Closed) Base URL: http://v8.googlecode.com/svn/branches/bleeding_edge/
Patch Set: Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2011 the V8 project authors. All rights reserved. 1 // Copyright 2011 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 813 matching lines...) Expand 10 before | Expand all | Expand 10 after
824 speed_up = true; 824 speed_up = true;
825 old_generation_space_used_at_start_of_incremental_ = 825 old_generation_space_used_at_start_of_incremental_ =
826 heap_->PromotedTotalSize(); 826 heap_->PromotedTotalSize();
827 } 827 }
828 828
829 if ((steps_count_ % kAllocationMarkingFactorSpeedupInterval) == 0 && 829 if ((steps_count_ % kAllocationMarkingFactorSpeedupInterval) == 0 &&
830 allocation_marking_factor_ < kMaxAllocationMarkingFactor) { 830 allocation_marking_factor_ < kMaxAllocationMarkingFactor) {
831 speed_up = true; 831 speed_up = true;
832 } 832 }
833 833
834 if (speed_up && 0) { 834 if (speed_up) {
835 allocation_marking_factor_ += kAllocationMarkingFactorSpeedup; 835 allocation_marking_factor_ += kAllocationMarkingFactorSpeedup;
836 allocation_marking_factor_ = 836 allocation_marking_factor_ =
837 static_cast<int>(allocation_marking_factor_ * 1.3); 837 static_cast<int>(allocation_marking_factor_ * 1.3);
838 if (FLAG_trace_gc) { 838 if (FLAG_trace_gc) {
839 PrintF("Marking speed increased to %d\n", allocation_marking_factor_); 839 PrintF("Marking speed increased to %d\n", allocation_marking_factor_);
840 } 840 }
841 } 841 }
842 842
843 if (FLAG_trace_incremental_marking || FLAG_trace_gc) { 843 if (FLAG_trace_incremental_marking || FLAG_trace_gc) {
844 double end = OS::TimeCurrentMillis(); 844 double end = OS::TimeCurrentMillis();
(...skipping 18 matching lines...) Expand all
863 bytes_rescanned_ = 0; 863 bytes_rescanned_ = 0;
864 allocation_marking_factor_ = kInitialAllocationMarkingFactor; 864 allocation_marking_factor_ = kInitialAllocationMarkingFactor;
865 } 865 }
866 866
867 867
868 int64_t IncrementalMarking::SpaceLeftInOldSpace() { 868 int64_t IncrementalMarking::SpaceLeftInOldSpace() {
869 return heap_->MaxOldGenerationSize() - heap_->PromotedSpaceSize(); 869 return heap_->MaxOldGenerationSize() - heap_->PromotedSpaceSize();
870 } 870 }
871 871
872 } } // namespace v8::internal 872 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698