Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9726)

Unified Diff: chrome/browser/ui/webui/options/core_options_handler.h

Issue 8467012: Refactor proxy handling for ChromeOS to not go through the CrosSettings interface. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fixed the nits. Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/webui/options/core_options_handler.h
diff --git a/chrome/browser/ui/webui/options/core_options_handler.h b/chrome/browser/ui/webui/options/core_options_handler.h
index 95c99036237d9faa254959a7d02b542832c7b70c..8542906c2946874ca592102944d28e1fd07b9931 100644
--- a/chrome/browser/ui/webui/options/core_options_handler.h
+++ b/chrome/browser/ui/webui/options/core_options_handler.h
@@ -47,14 +47,14 @@ class CoreOptionsHandler : public OptionsPageUIHandler {
protected:
// Fetches a pref value of given |pref_name|.
// Note that caller owns the returned Value.
- virtual Value* FetchPref(const std::string& pref_name);
+ virtual base::Value* FetchPref(const std::string& pref_name);
// Observes a pref of given |pref_name|.
virtual void ObservePref(const std::string& pref_name);
// Sets a pref |value| to given |pref_name|.
virtual void SetPref(const std::string& pref_name,
- const Value* value,
+ const base::Value* value,
const std::string& metric);
// Clears pref value for given |pref_name|.
@@ -64,7 +64,7 @@ class CoreOptionsHandler : public OptionsPageUIHandler {
virtual void StopObservingPref(const std::string& path);
// Records a user metric action for the given value.
- void ProcessUserMetric(const Value* value,
+ void ProcessUserMetric(const base::Value* value,
const std::string& metric);
// Notifies registered JS callbacks on change in |pref_name| preference.
« no previous file with comments | « chrome/browser/ui/webui/options/chromeos/proxy_handler.cc ('k') | chrome/browser/ui/webui/options/core_options_handler.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698