Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Unified Diff: chrome/browser/chromeos/proxy_config_service_impl.h

Issue 8467012: Refactor proxy handling for ChromeOS to not go through the CrosSettings interface. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Addressed comments. Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/proxy_config_service_impl.h
diff --git a/chrome/browser/chromeos/proxy_config_service_impl.h b/chrome/browser/chromeos/proxy_config_service_impl.h
index dc2561888c2aff6f2f0185e004877124162afee0..7e38fb55bacb761aa3dc4045fdfded3a8e419844 100644
--- a/chrome/browser/chromeos/proxy_config_service_impl.h
+++ b/chrome/browser/chromeos/proxy_config_service_impl.h
@@ -182,6 +182,14 @@ class ProxyConfigServiceImpl
// Only valid for MODE_SINGLE_PROXY or MODE_PROXY_PER_SCHEME.
bool UISetProxyConfigBypassRules(const net::ProxyBypassRules& bypass_rules);
+ // Add/Remove callback functions for network changed by the UI.
kuan 2011/11/10 14:27:25 s/network/notification when network to be viewed i
pastarmovj 2011/11/10 16:08:26 Done.
+ void AddNotificationCallback(base::Closure callback);
+ void RemoveNotificationCallback(base::Closure callback);
+
+ // PrefProxyConfigTrackerImpl implementation.
+ virtual void OnProxyConfigChanged(ProxyPrefs::ConfigState config_state,
+ const net::ProxyConfig& config) OVERRIDE;
+
// Implementation for SignedSettings::Delegate
virtual void OnSettingsOpCompleted(SignedSettings::ReturnCode code,
std::string value) OVERRIDE;
@@ -193,10 +201,6 @@ class ProxyConfigServiceImpl
virtual void OnNetworkChanged(NetworkLibrary* cros,
const Network* network) OVERRIDE;
- // PrefProxyConfigTrackerImpl implementation.
- virtual void OnProxyConfigChanged(ProxyPrefs::ConfigState config_state,
- const net::ProxyConfig& config) OVERRIDE;
-
// Register UseShardProxies preference.
static void RegisterPrefs(PrefService* pref_service);
@@ -293,6 +297,9 @@ class ProxyConfigServiceImpl
// Operation to retrieve proxy setting from device.
scoped_refptr<SignedSettings> retrieve_property_op_;
+ // Callbacks for notification when netowrk has been changed from the UI.
kuan 2011/11/10 14:27:25 s/netowrk/network to be viewed/
pastarmovj 2011/11/10 16:08:26 Done.
+ std::vector<base::Closure> callbacks_;
+
DISALLOW_COPY_AND_ASSIGN(ProxyConfigServiceImpl);
};

Powered by Google App Engine
This is Rietveld 408576698