Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(76)

Unified Diff: chrome/browser/ui/webui/options/chromeos/internet_options_handler.cc

Issue 8467012: Refactor proxy handling for ChromeOS to not go through the CrosSettings interface. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/webui/options/chromeos/internet_options_handler.cc
diff --git a/chrome/browser/ui/webui/options/chromeos/internet_options_handler.cc b/chrome/browser/ui/webui/options/chromeos/internet_options_handler.cc
index cccdc5443035d0b1f2356b1434b26f7d01b0d9d7..db86840b1c25a1e613937a7821675c0ac45d1e49 100644
--- a/chrome/browser/ui/webui/options/chromeos/internet_options_handler.cc
+++ b/chrome/browser/ui/webui/options/chromeos/internet_options_handler.cc
@@ -29,9 +29,11 @@
#include "chrome/browser/chromeos/login/user_manager.h"
#include "chrome/browser/chromeos/mobile_config.h"
#include "chrome/browser/chromeos/options/network_config_view.h"
+#include "chrome/browser/chromeos/proxy_config_service_impl.h"
#include "chrome/browser/chromeos/sim_dialog_delegate.h"
#include "chrome/browser/chromeos/status/network_menu_icon.h"
#include "chrome/browser/chromeos/user_cros_settings_provider.h"
+#include "chrome/browser/net/pref_proxy_config_tracker.h"
#include "chrome/browser/profiles/profile.h"
#include "chrome/browser/ui/browser.h"
#include "chrome/browser/ui/browser_list.h"
@@ -54,8 +56,7 @@
static const char kOtherNetworksFakePath[] = "?";
InternetOptionsHandler::InternetOptionsHandler()
- : chromeos::CrosOptionsPageUIHandler(NULL),
- proxy_settings_(NULL) {
+ : chromeos::CrosOptionsPageUIHandler(NULL) {
registrar_.Add(this, chrome::NOTIFICATION_REQUIRE_PIN_SETTING_CHANGE_ENDED,
content::NotificationService::AllSources());
registrar_.Add(this, chrome::NOTIFICATION_ENTER_PIN_ENDED,
@@ -690,8 +691,14 @@ void InternetOptionsHandler::SetIPConfigCallback(const ListValue* args) {
void InternetOptionsHandler::PopulateDictionaryDetails(
const chromeos::Network* network) {
DCHECK(network);
- if (proxy_settings())
- proxy_settings()->SetCurrentNetwork(network->service_path());
+
+ Profile::FromWebUI(web_ui_)->GetProxyConfigTracker()->UISetCurrentNetwork(
+ network->service_path());
+ content::NotificationService::current()->Notify(
+ chrome::NOTIFICATION_CURRENT_NETWORK_CHANGED,
+ content::NotificationService::AllSources(),
+ content::NotificationService::NoDetails());
+
DictionaryValue dictionary;
std::string hardware_address;
chromeos::NetworkIPConfigVector ipconfigs = cros_->GetIPConfigs(
@@ -775,16 +782,6 @@ void InternetOptionsHandler::PopulateDictionaryDetails(
"options.InternetOptions.showDetailedInfo", dictionary);
}
-chromeos::ProxyCrosSettingsProvider* InternetOptionsHandler::proxy_settings() {
- if (!proxy_settings_) {
- proxy_settings_ = static_cast<chromeos::ProxyCrosSettingsProvider*>(
- chromeos::CrosSettings::Get()->GetProvider("cros.session.proxy"));
- if (!proxy_settings_)
- NOTREACHED() << "Error getting access to proxy cros settings provider";
- }
- return proxy_settings_;
-}
-
void InternetOptionsHandler::PopulateWifiDetails(
const chromeos::WifiNetwork* wifi,
DictionaryValue* dictionary) {

Powered by Google App Engine
This is Rietveld 408576698