Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(218)

Side by Side Diff: chrome/browser/ui/webui/chromeos/proxy_settings_ui.h

Issue 8467012: Refactor proxy handling for ChromeOS to not go through the CrosSettings interface. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Addressed comments. Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_UI_WEBUI_CHROMEOS_PROXY_SETTINGS_UI_H_ 5 #ifndef CHROME_BROWSER_UI_WEBUI_CHROMEOS_PROXY_SETTINGS_UI_H_
6 #define CHROME_BROWSER_UI_WEBUI_CHROMEOS_PROXY_SETTINGS_UI_H_ 6 #define CHROME_BROWSER_UI_WEBUI_CHROMEOS_PROXY_SETTINGS_UI_H_
7 #pragma once 7 #pragma once
8 8
9 #include "chrome/browser/chromeos/proxy_cros_settings_provider.h"
10 #include "chrome/browser/ui/webui/chrome_web_ui.h" 9 #include "chrome/browser/ui/webui/chrome_web_ui.h"
11 #include "chrome/browser/ui/webui/options/options_ui.h" 10 #include "chrome/browser/ui/webui/options/options_ui.h"
12 11
13 namespace chromeos { 12 namespace chromeos {
14 13
15 class ProxyHandler; 14 class ProxyHandler;
16 15
17 // A WebUI to host proxy settings splitted from settings page for better 16 // A WebUI to host proxy settings splitted from settings page for better
18 // performance. 17 // performance.
19 class ProxySettingsUI : public ChromeWebUI, 18 class ProxySettingsUI : public ChromeWebUI,
20 public OptionsPageUIHandlerHost { 19 public OptionsPageUIHandlerHost {
21 public: 20 public:
22 explicit ProxySettingsUI(TabContents* contents); 21 explicit ProxySettingsUI(TabContents* contents);
23 virtual ~ProxySettingsUI(); 22 virtual ~ProxySettingsUI();
24 23
25 private: 24 private:
26 // Overridden from OptionsPageUIHandlerHost: 25 // Overridden from OptionsPageUIHandlerHost:
27 virtual void InitializeHandlers() OVERRIDE; 26 virtual void InitializeHandlers() OVERRIDE;
28 27
29 chromeos::ProxyCrosSettingsProvider* proxy_settings();
30
31 chromeos::ProxyCrosSettingsProvider* proxy_settings_; // Weak ptr.
32 chromeos::ProxyHandler* proxy_handler_; // Weak ptr. 28 chromeos::ProxyHandler* proxy_handler_; // Weak ptr.
33 29
34 DISALLOW_COPY_AND_ASSIGN(ProxySettingsUI); 30 DISALLOW_COPY_AND_ASSIGN(ProxySettingsUI);
35 }; 31 };
36 32
37 } // namespace chromeos 33 } // namespace chromeos
38 34
39 #endif // CHROME_BROWSER_UI_WEBUI_CHROMEOS_PROXY_SETTINGS_UI_H_ 35 #endif // CHROME_BROWSER_UI_WEBUI_CHROMEOS_PROXY_SETTINGS_UI_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698