Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Side by Side Diff: src/objects.cc

Issue 8467010: Refactor embedded pointer visitors for the serializer (Closed)
Patch Set: Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/objects.h ('k') | src/serialize.h » ('j') | src/serialize.cc » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2011 the V8 project authors. All rights reserved. 1 // Copyright 2011 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 7706 matching lines...) Expand 10 before | Expand all | Expand 10 after
7717 VisitPointer(&target); 7717 VisitPointer(&target);
7718 CHECK_EQ(target, old_target); // VisitPointer doesn't change Code* *target. 7718 CHECK_EQ(target, old_target); // VisitPointer doesn't change Code* *target.
7719 } 7719 }
7720 7720
7721 7721
7722 void ObjectVisitor::VisitEmbeddedPointer(RelocInfo* rinfo) { 7722 void ObjectVisitor::VisitEmbeddedPointer(RelocInfo* rinfo) {
7723 ASSERT(rinfo->rmode() == RelocInfo::EMBEDDED_OBJECT); 7723 ASSERT(rinfo->rmode() == RelocInfo::EMBEDDED_OBJECT);
7724 VisitPointer(rinfo->target_object_address()); 7724 VisitPointer(rinfo->target_object_address());
7725 } 7725 }
7726 7726
7727 void ObjectVisitor::VisitExternalReference(RelocInfo* rinfo) {
7728 Address* p = rinfo->target_reference_address();
7729 VisitExternalReferences(p, p+1);
Michael Starzinger 2011/11/09 10:46:19 Space before and after operator (i.e. "p + 1").
7730 }
7727 7731
7728 void Code::InvalidateRelocation() { 7732 void Code::InvalidateRelocation() {
7729 set_relocation_info(GetHeap()->empty_byte_array()); 7733 set_relocation_info(GetHeap()->empty_byte_array());
7730 } 7734 }
7731 7735
7732 7736
7733 void Code::Relocate(intptr_t delta) { 7737 void Code::Relocate(intptr_t delta) {
7734 for (RelocIterator it(this, RelocInfo::kApplyMask); !it.done(); it.next()) { 7738 for (RelocIterator it(this, RelocInfo::kApplyMask); !it.done(); it.next()) {
7735 it.rinfo()->apply(delta); 7739 it.rinfo()->apply(delta);
7736 } 7740 }
(...skipping 5018 matching lines...) Expand 10 before | Expand all | Expand 10 after
12755 if (break_point_objects()->IsUndefined()) return 0; 12759 if (break_point_objects()->IsUndefined()) return 0;
12756 // Single break point. 12760 // Single break point.
12757 if (!break_point_objects()->IsFixedArray()) return 1; 12761 if (!break_point_objects()->IsFixedArray()) return 1;
12758 // Multiple break points. 12762 // Multiple break points.
12759 return FixedArray::cast(break_point_objects())->length(); 12763 return FixedArray::cast(break_point_objects())->length();
12760 } 12764 }
12761 #endif // ENABLE_DEBUGGER_SUPPORT 12765 #endif // ENABLE_DEBUGGER_SUPPORT
12762 12766
12763 12767
12764 } } // namespace v8::internal 12768 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « src/objects.h ('k') | src/serialize.h » ('j') | src/serialize.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698