Issue 8467005: Publish the source for CFInstall.min.js .

Issue 8467005: Publish the source for CFInstall.min.js . (Closed)

Created:
9 years, 1 month ago by erikwright (departed)

Modified:
8 years, 9 months ago

Reviewers:
Steve Block, robertshield

CC:
chromium-reviews, amit, Steve Block

Base URL:
http://git.chromium.org/chromium/src.git@master

Visibility:
Public.

Description

Publish the source for CFInstall.min.js . BUG=None TEST=./build.sh and then load file:///path/to/local_testing.html in IE (without CF). Click the "This site requires Chrome Frame" link and observe the dialog that pops up. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=108675

Patch Set 1 #

Patch Set 2 : Line length fixes. #

Total comments: 1

Created: 9 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1394 lines, -0 lines)			Patch
A	chrome_frame/cfinstall/.gitignore	View		1 chunk	+2 lines, -0 lines	0 comments	Download
A	chrome_frame/cfinstall/README	View		1 chunk	+7 lines, -0 lines	0 comments	Download
A	chrome_frame/cfinstall/build.sh	View		1 chunk	+62 lines, -0 lines	0 comments	Download
A	chrome_frame/cfinstall/examples/jquery.html	View	1	1 chunk	+71 lines, -0 lines	1 comment	Download
A	chrome_frame/cfinstall/examples/local_testing.html	View	1	1 chunk	+38 lines, -0 lines	0 comments	Download
A	chrome_frame/cfinstall/examples/simple.html	View	1	1 chunk	+25 lines, -0 lines	0 comments	Download
A	chrome_frame/cfinstall/src/common/cf-interactiondelegate-externs.js	View		1 chunk	+4 lines, -0 lines	0 comments	Download
A	chrome_frame/cfinstall/src/common/interactiondelegate.js	View		1 chunk	+49 lines, -0 lines	0 comments	Download
A	chrome_frame/cfinstall/src/implementation/crossdomaininstall.js	View		1 chunk	+111 lines, -0 lines	0 comments	Download
A	chrome_frame/cfinstall/src/implementation/dialoginteractiondelegate.js	View		1 chunk	+161 lines, -0 lines	0 comments	Download
A	chrome_frame/cfinstall/src/miniclosure/base.js	View		1 chunk	+77 lines, -0 lines	0 comments	Download
A	chrome_frame/cfinstall/src/miniclosure/style.js	View		1 chunk	+29 lines, -0 lines	0 comments	Download
A	chrome_frame/cfinstall/src/stub/cf-activex-externs.js	View		1 chunk	+8 lines, -0 lines	0 comments	Download
A	chrome_frame/cfinstall/src/stub/cfinstall.js	View		1 chunk	+118 lines, -0 lines	0 comments	Download
A	chrome_frame/cfinstall/src/stub/chromeframe.js	View		1 chunk	+90 lines, -0 lines	0 comments	Download
A	chrome_frame/cfinstall/src/stub/frame.js	View		1 chunk	+46 lines, -0 lines	0 comments	Download
A	chrome_frame/cfinstall/src/stub/inlinedelegate.js	View		1 chunk	+87 lines, -0 lines	0 comments	Download
A	chrome_frame/cfinstall/src/stub/installer.js	View		1 chunk	+43 lines, -0 lines	0 comments	Download
A	chrome_frame/cfinstall/src/stub/overlaydelegate.js	View		1 chunk	+156 lines, -0 lines	0 comments	Download
A	chrome_frame/cfinstall/src/stub/prompt.js	View		1 chunk	+210 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

robertshield

On 2011/11/04 15:11:40, erikwright wrote: Rubber stamp LGTM

9 years, 1 month ago (2011-11-04 15:47:11 UTC) #2

Steve Block

8 years, 9 months ago (2012-03-19 12:59:35 UTC) #3

http://codereview.chromium.org/8467005/diff/22/chrome_frame/cfinstall/example...
File chrome_frame/cfinstall/examples/jquery.html (right):

http://codereview.chromium.org/8467005/diff/22/chrome_frame/cfinstall/example...
chrome_frame/cfinstall/examples/jquery.html:2: Copyright 2011 Google Inc. All
rights reserved.
Is this (and the other files under examples/) intended to be copyright Google?
Other JS files in this CL seem to use either the standard Chromium copyright and
license, or no license.

Expand Messages | Collapse Messages