Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(259)

Side by Side Diff: chrome/browser/accessibility/renderer_accessibility_browsertest.cc

Issue 8467002: Fix double-initialization of CComModule. (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include <string> 5 #include <string>
6 #include <vector> 6 #include <vector>
7 7
8 #include "base/utf_string_conversions.h" 8 #include "base/utf_string_conversions.h"
9 #include "chrome/browser/ui/browser.h" 9 #include "chrome/browser/ui/browser.h"
10 #include "chrome/browser/ui/browser_window.h" 10 #include "chrome/browser/ui/browser_window.h"
11 #include "chrome/common/render_messages.h" 11 #include "chrome/common/render_messages.h"
12 #include "chrome/test/base/in_process_browser_test.h" 12 #include "chrome/test/base/in_process_browser_test.h"
13 #include "chrome/test/base/ui_test_utils.h" 13 #include "chrome/test/base/ui_test_utils.h"
14 #include "content/browser/renderer_host/render_view_host.h" 14 #include "content/browser/renderer_host/render_view_host.h"
15 #include "content/browser/renderer_host/render_widget_host.h" 15 #include "content/browser/renderer_host/render_widget_host.h"
16 #include "content/browser/renderer_host/render_widget_host_view.h" 16 #include "content/browser/renderer_host/render_widget_host_view.h"
17 #include "content/browser/tab_contents/tab_contents.h" 17 #include "content/browser/tab_contents/tab_contents.h"
18 #include "content/public/browser/notification_service.h" 18 #include "content/public/browser/notification_service.h"
19 #include "content/public/browser/notification_types.h" 19 #include "content/public/browser/notification_types.h"
20 20
21 #if defined(OS_WIN) 21 #if defined(OS_WIN)
22 #include <atlbase.h> 22 #include <atlbase.h>
23 #include <atlcom.h> 23 #include <atlcom.h>
24 #include "base/win/atl_module.h"
24 #endif 25 #endif
25 26
26 using webkit_glue::WebAccessibility; 27 using webkit_glue::WebAccessibility;
27 28
28 namespace { 29 namespace {
29 30
30 class RendererAccessibilityBrowserTest : public InProcessBrowserTest { 31 class RendererAccessibilityBrowserTest : public InProcessBrowserTest {
31 public: 32 public:
32 RendererAccessibilityBrowserTest() {} 33 RendererAccessibilityBrowserTest() {}
33 34
(...skipping 30 matching lines...) Expand all
64 std::string GetAttr(const WebAccessibility& node, 65 std::string GetAttr(const WebAccessibility& node,
65 const WebAccessibility::StringAttribute attr); 66 const WebAccessibility::StringAttribute attr);
66 int GetIntAttr(const WebAccessibility& node, 67 int GetIntAttr(const WebAccessibility& node,
67 const WebAccessibility::IntAttribute attr); 68 const WebAccessibility::IntAttribute attr);
68 bool GetBoolAttr(const WebAccessibility& node, 69 bool GetBoolAttr(const WebAccessibility& node,
69 const WebAccessibility::BoolAttribute attr); 70 const WebAccessibility::BoolAttribute attr);
70 }; 71 };
71 72
72 void RendererAccessibilityBrowserTest::SetUpInProcessBrowserTestFixture() { 73 void RendererAccessibilityBrowserTest::SetUpInProcessBrowserTestFixture() {
73 #if defined(OS_WIN) 74 #if defined(OS_WIN)
74 // ATL might need a pointer to a COM module, depending on the build config. 75 base::win::CreateATLModuleIfNeeded();
75 if (!_pAtlModule) {
76 static CComModule module;
77 _pAtlModule = &module;
78 }
79
80 // Make sure COM is initialized for this thread; it's safe to call twice.
81 ::CoInitialize(NULL); 76 ::CoInitialize(NULL);
82 #endif 77 #endif
83 } 78 }
84 79
85 void RendererAccessibilityBrowserTest::TearDownInProcessBrowserTestFixture() { 80 void RendererAccessibilityBrowserTest::TearDownInProcessBrowserTestFixture() {
86 #if defined(OS_WIN) 81 #if defined(OS_WIN)
87 ::CoUninitialize(); 82 ::CoUninitialize();
88 #endif 83 #endif
89 } 84 }
90 85
(...skipping 359 matching lines...) Expand 10 before | Expand all | Expand 10 after
450 const WebAccessibility& tree = GetWebAccessibilityTree(); 445 const WebAccessibility& tree = GetWebAccessibilityTree();
451 446
452 ASSERT_EQ(1U, tree.children.size()); 447 ASSERT_EQ(1U, tree.children.size());
453 const WebAccessibility& textbox = tree.children[0]; 448 const WebAccessibility& textbox = tree.children[0];
454 449
455 EXPECT_EQ( 450 EXPECT_EQ(
456 true, GetBoolAttr(textbox, WebAccessibility::ATTR_CAN_SET_VALUE)); 451 true, GetBoolAttr(textbox, WebAccessibility::ATTR_CAN_SET_VALUE));
457 } 452 }
458 453
459 } // namespace 454 } // namespace
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698