Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(185)

Issue 8466001: Update CaptureVideoDecoder to handle DeviceInfoReceived() calls. (Closed)

Created:
9 years, 1 month ago by scherkus (not reviewing)
Modified:
9 years, 1 month ago
CC:
chromium-reviews, hclam+watch_chromium.org, ddorwin+watch_chromium.org, fischman+watch_chromium.org, jam, Paweł Hajdan Jr., acolwell+watch_chromium.org, annacc+watch_chromium.org, dpranke-watch+content_chromium.org, joi+watch-content_chromium.org, darin-cc_chromium.org, ajwong+watch_chromium.org, vrk (LEFT CHROMIUM), scherkus (not reviewing), ihf+watch_chromium.org
Visibility:
Public.

Description

Update CaptureVideoDecoder to handle DeviceInfoReceived() calls. Previously the natural size output by the video decoder was not updated based on the device information reported by the capture device. Also cleaned up logging statements and unit tests. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=108685

Patch Set 1 #

Patch Set 2 : cleanup #

Total comments: 2

Patch Set 3 : fix #

Patch Set 4 : buffer count #

Unified diffs Side-by-side diffs Delta from patch set Stats (+131 lines, -54 lines) Patch
M content/renderer/media/capture_video_decoder.h View 1 chunk +3 lines, -0 lines 0 comments Download
M content/renderer/media/capture_video_decoder.cc View 1 6 chunks +33 lines, -17 lines 0 comments Download
M content/renderer/media/capture_video_decoder_unittest.cc View 1 2 3 6 chunks +95 lines, -37 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
wjia(left Chromium)
Thanks for the patch, Andrew! http://codereview.chromium.org/8466001/diff/2001/content/renderer/media/capture_video_decoder_unittest.cc File content/renderer/media/capture_video_decoder_unittest.cc (right): http://codereview.chromium.org/8466001/diff/2001/content/renderer/media/capture_video_decoder_unittest.cc#newcode159 content/renderer/media/capture_video_decoder_unittest.cc:159: void Read() { Read() ...
9 years, 1 month ago (2011-11-04 03:31:16 UTC) #1
scherkus (not reviewing)
http://codereview.chromium.org/8466001/diff/2001/content/renderer/media/capture_video_decoder_unittest.cc File content/renderer/media/capture_video_decoder_unittest.cc (right): http://codereview.chromium.org/8466001/diff/2001/content/renderer/media/capture_video_decoder_unittest.cc#newcode159 content/renderer/media/capture_video_decoder_unittest.cc:159: void Read() { On 2011/11/04 03:31:16, wjia wrote: > ...
9 years, 1 month ago (2011-11-04 16:32:57 UTC) #2
wjia(left Chromium)
lgtm
9 years, 1 month ago (2011-11-04 16:36:44 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/scherkus@chromium.org/8466001/6006
9 years, 1 month ago (2011-11-04 16:37:14 UTC) #4
commit-bot: I haz the power
9 years, 1 month ago (2011-11-04 18:32:25 UTC) #5
Change committed as 108685

Powered by Google App Engine
This is Rietveld 408576698