Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
8465017:
Improve documentation of policies for the template generator. (Closed)
|
Created:
9 years, 1 month ago by pastarmovj Modified:
9 years, 1 month ago CC:
chromium-reviews Base URL:
svn://svn.chromium.org/chrome/trunk/src Visibility:
Public. |
DescriptionImprove documentation of policies for the template generator.
Particularly make sure all policies have description for the default state
which will be used if the policy is not set.
BUG=100033
TEST=Smiling admins.
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=110292
Patch Set 1 #
Total comments: 124
Patch Set 2 : Addressed comments. #Messages
Total messages: 8 (0 generated)
@gwilson: Can you please review the changes to the documentation. @mnissler: I will need OWNER agreement to commit that if it is fine.
http://codereview.chromium.org/8465017/diff/1/chrome/app/policy/policy_templa... File chrome/app/policy/policy_templates.json (right): http://codereview.chromium.org/8465017/diff/1/chrome/app/policy/policy_templa... chrome/app/policy/policy_templates.json:214: If this policy is left not set the default value will be used which is enabled and the user will be able to change it.''', a little awkward. How about: If this policy is left not set, this will be enabled but the user will be able to change it. http://codereview.chromium.org/8465017/diff/1/chrome/app/policy/policy_templa... chrome/app/policy/policy_templates.json:232: If this policy is left not set the default value will be used which is enabled and the user will be able to change it.''', Same here, how about: If this policy is left not set, this will be enabled but the user will be able to change it. http://codereview.chromium.org/8465017/diff/1/chrome/app/policy/policy_templa... chrome/app/policy/policy_templates.json:246: If this policy is left not set the default value will be used which is enabled and the user will be able to change it.''', same here. http://codereview.chromium.org/8465017/diff/1/chrome/app/policy/policy_templa... chrome/app/policy/policy_templates.json:262: If this policy is left not set the default value will be used which is disabled and the user will be able to change it.''', same here. http://codereview.chromium.org/8465017/diff/1/chrome/app/policy/policy_templa... chrome/app/policy/policy_templates.json:296: If this policy is left not set the default value will be used which is enabled and the user will be able to change it. same here. http://codereview.chromium.org/8465017/diff/1/chrome/app/policy/policy_templa... chrome/app/policy/policy_templates.json:316: If this policy is left not set the default value will be used which is enabled and the user will be able to use incognito mode.''', Same here. How about: If this policy is left not set, this will be enabled and the user will be able to use incognito mode. http://codereview.chromium.org/8465017/diff/1/chrome/app/policy/policy_templa... chrome/app/policy/policy_templates.json:404: If this policy is left not set the default value will be used which is enabled.''', How about: If this policy is left not set the setting will be enabled. http://codereview.chromium.org/8465017/diff/1/chrome/app/policy/policy_templa... chrome/app/policy/policy_templates.json:422: If this policy is left not set the default value will be used which is enabled and the user will be able to change it.''', same here. http://codereview.chromium.org/8465017/diff/1/chrome/app/policy/policy_templa... chrome/app/policy/policy_templates.json:439: If this policy is left not set the default value will be used which is enabled and the user will be able to change it.''', same http://codereview.chromium.org/8465017/diff/1/chrome/app/policy/policy_templa... chrome/app/policy/policy_templates.json:457: If this policy is left not set the default value will be used which is enabled and the user will be able to change it.''', same. http://codereview.chromium.org/8465017/diff/1/chrome/app/policy/policy_templa... chrome/app/policy/policy_templates.json:475: If this policy is left not set the default value chosen upon installation will be used which is enabled and the user will be able to change it.''', Awkward. Maybe: If this policy is left not set the setting will be what the user chose upon installation / first run. http://codereview.chromium.org/8465017/diff/1/chrome/app/policy/policy_templa... chrome/app/policy/policy_templates.json:499: If this policy is left not set the default value will be used which is enabled and the user will be able to change it.''', same here. http://codereview.chromium.org/8465017/diff/1/chrome/app/policy/policy_templa... chrome/app/policy/policy_templates.json:613: If this policy is left not set synchronization will be available for the user to choose whether to use it or not.''', synchronization --> Google Sync http://codereview.chromium.org/8465017/diff/1/chrome/app/policy/policy_templa... chrome/app/policy/policy_templates.json:672: If set to disabled side data will not be cleared on exit. side data -> site data http://codereview.chromium.org/8465017/diff/1/chrome/app/policy/policy_templa... chrome/app/policy/policy_templates.json:866: If this policy is left unset the default will be used which is using all four schemes.''', If this policy is left not set, all four schemes will be used. http://codereview.chromium.org/8465017/diff/1/chrome/app/policy/policy_templa... chrome/app/policy/policy_templates.json:944: Typically this is disabled (which is also the case if this policy is not set) as a phishing defense.''', How about leaving the previous sentence as-is and appending another, as so: Typically this is disabled as a phishing defense. If this policy is not set, this is disabled and third-party sub-content will not be allowed to pop up a HTTP Basic Auth dialog box. http://codereview.chromium.org/8465017/diff/1/chrome/app/policy/policy_templa... chrome/app/policy/policy_templates.json:966: If this policy is left not set the user can install any extension on the system.''', (probably don't need 'on the system') http://codereview.chromium.org/8465017/diff/1/chrome/app/policy/policy_templa... chrome/app/policy/policy_templates.json:998: If this policy is left not set the user can uninstall any extension on the system.''', (probably don't need 'on the system') http://codereview.chromium.org/8465017/diff/1/chrome/app/policy/policy_templa... chrome/app/policy/policy_templates.json:1019: Leaving this policy not set will allow the user to choose whether to show the home button on his own.''', probably don't need 'on his own' http://codereview.chromium.org/8465017/diff/1/chrome/app/policy/policy_templa... chrome/app/policy/policy_templates.json:1108: If this policy is left not set the default value will be used which is disabled and the user will be able to change it.''', same here. http://codereview.chromium.org/8465017/diff/1/chrome/app/policy/policy_templa... chrome/app/policy/policy_templates.json:1134: If this policy is left not set the default value will be used which is enabled and the user will be able to set his search provider list.''', If this policy is left not set, the default search provider is enabled, and the user will be able to set the search provider list. http://codereview.chromium.org/8465017/diff/1/chrome/app/policy/policy_templa... chrome/app/policy/policy_templates.json:1158: This policy is optional if not set no keyword will activate the search provider. This policy is optional. If not set, no keyword will activate the search provider. http://codereview.chromium.org/8465017/diff/1/chrome/app/policy/policy_templa... chrome/app/policy/policy_templates.json:1172: This option must not be left not set when the 'DefaultSearchProviderEnabled' policy is enabled and will only be considered if this is the case.''', This option must be set when... ...and will only be respected if... http://codereview.chromium.org/8465017/diff/1/chrome/app/policy/policy_templa... chrome/app/policy/policy_templates.json:1184: This policy is optional if not set no suggest URL will be used. This policy is optional. If not set, no suggest URL will be used. http://codereview.chromium.org/8465017/diff/1/chrome/app/policy/policy_templa... chrome/app/policy/policy_templates.json:1186: This policy is only considered if the 'DefaultSearchProviderEnabled' policy is enabled.''', considered -> respected http://codereview.chromium.org/8465017/diff/1/chrome/app/policy/policy_templa... chrome/app/policy/policy_templates.json:1198: This policy is optional if not set no instant search results will be provided. This policy is optional. If not set, no instant search results will be provided. http://codereview.chromium.org/8465017/diff/1/chrome/app/policy/policy_templa... chrome/app/policy/policy_templates.json:1200: This policy is only considered if the 'DefaultSearchProviderEnabled' policy is enabled.''', considered -> respected http://codereview.chromium.org/8465017/diff/1/chrome/app/policy/policy_templa... chrome/app/policy/policy_templates.json:1212: This policy is optional if not set no icon will be present for the search provider. same here. New sentence after 'optional' http://codereview.chromium.org/8465017/diff/1/chrome/app/policy/policy_templa... chrome/app/policy/policy_templates.json:1214: This policy is only considered if the 'DefaultSearchProviderEnabled' policy is enabled.''', considered -> respected http://codereview.chromium.org/8465017/diff/1/chrome/app/policy/policy_templa... chrome/app/policy/policy_templates.json:1226: This policy is optional if not set the default will be used which is UTF-8. This policy is optional. If not set, UTF-8 is used. http://codereview.chromium.org/8465017/diff/1/chrome/app/policy/policy_templa... chrome/app/policy/policy_templates.json:1228: This policy is only considered if the 'DefaultSearchProviderEnabled' policy is enabled.''', considered -> respected http://codereview.chromium.org/8465017/diff/1/chrome/app/policy/policy_templa... chrome/app/policy/policy_templates.json:1260: If this policy is left not set the default value will be used which is 'AllowCookies' and the user will be able to change it.''', If this policy is left not set, 'AllowCookies' will be used and the user will be able to change it. http://codereview.chromium.org/8465017/diff/1/chrome/app/policy/policy_templa... chrome/app/policy/policy_templates.json:1284: If this policy is left not set the default value will be used which is 'AllowImages' and the user will be able to change it.''', If this policy is left not set, 'AllowImages' will be used and the user will be able to change it. http://codereview.chromium.org/8465017/diff/1/chrome/app/policy/policy_templa... chrome/app/policy/policy_templates.json:1308: If this policy is left not set the default value will be used which is 'AllowJavaScript' and the user will be able to change it.''', If this policy is left not set, 'AllowJavaScript' will be used and the user will be able to change it. http://codereview.chromium.org/8465017/diff/1/chrome/app/policy/policy_templa... chrome/app/policy/policy_templates.json:1332: If this policy is left not set the default value will be used which is 'AllowPlugins' and the user will be able to change it.''', If this policy is left not set, 'AllowPlugins' will be used and the user will be able to change it. http://codereview.chromium.org/8465017/diff/1/chrome/app/policy/policy_templa... chrome/app/policy/policy_templates.json:1356: If this policy is left not set the default value will be used which is 'BlockPopups' and the user will be able to change it.''', If this policy is left not set, 'BlockPopups' will be used and the user will be able to change it. http://codereview.chromium.org/8465017/diff/1/chrome/app/policy/policy_templa... chrome/app/policy/policy_templates.json:1385: If this policy is left not set the default value will be used which is 'AskNotifications' and the user will be able to change it.''', If this policy is left not set, 'AskNotifications' will be used and the user will be able to change it. http://codereview.chromium.org/8465017/diff/1/chrome/app/policy/policy_templa... chrome/app/policy/policy_templates.json:1414: If this policy is left not set the default value will be used which is 'AskGeolocation' and the user will be able to change it.''', If this policy is left not set, 'AskGeolocation' will be used and the user will be able to change it. http://codereview.chromium.org/8465017/diff/1/chrome/app/policy/policy_templa... chrome/app/policy/policy_templates.json:1438: If this policy is left not set the global default value will be used for all sites either from the 'DefaultCookiesSetting' policy or what the user has chosen if it is not set too.''', can we change this to ...all sites either from the 'DefaultCookiesSetting' policy if it is set, or the user's personal configuration otherwise. http://codereview.chromium.org/8465017/diff/1/chrome/app/policy/policy_templa... chrome/app/policy/policy_templates.json:1450: If this policy is left not set the global default value will be used for all sites either from the 'DefaultCookiesSetting' policy or what the user has chosen if it is not set too.''', same here http://codereview.chromium.org/8465017/diff/1/chrome/app/policy/policy_templa... chrome/app/policy/policy_templates.json:1462: If this policy is left not set the global default value will be used for all sites either from the 'DefaultCookiesSetting' policy or what the user has chosen if it is not set too.''', same http://codereview.chromium.org/8465017/diff/1/chrome/app/policy/policy_templa... chrome/app/policy/policy_templates.json:1474: If this policy is left not set the global default value will be used for all sites either from the 'DefaultImagesSetting' policy or what the user has chosen if it is not set too.''', same http://codereview.chromium.org/8465017/diff/1/chrome/app/policy/policy_templa... chrome/app/policy/policy_templates.json:1486: If this policy is left not set the global default value will be used for all sites either from the 'DefaultImagesSetting' policy or what the user has chosen if it is not set too.''', same. http://codereview.chromium.org/8465017/diff/1/chrome/app/policy/policy_templa... chrome/app/policy/policy_templates.json:1498: If this policy is left not set the global default value will be used for all sites either from the 'DefaultJavaScriptSetting' policy or what the user has chosen if it is not set too.''', same http://codereview.chromium.org/8465017/diff/1/chrome/app/policy/policy_templa... chrome/app/policy/policy_templates.json:1510: If this policy is left not set the global default value will be used for all sites either from the 'DefaultJavaScriptSetting' policy or what the user has chosen if it is not set too.''', same. http://codereview.chromium.org/8465017/diff/1/chrome/app/policy/policy_templa... chrome/app/policy/policy_templates.json:1522: If this policy is left not set the global default value will be used for all sites either from the 'DefaultPluginsSetting' policy or what the user has chosen if it is not set too.''', same http://codereview.chromium.org/8465017/diff/1/chrome/app/policy/policy_templa... chrome/app/policy/policy_templates.json:1534: If this policy is left not set the global default value will be used for all sites either from the 'DefaultPluginsSetting' policy or what the user has chosen if it is not set too.''', same. http://codereview.chromium.org/8465017/diff/1/chrome/app/policy/policy_templa... chrome/app/policy/policy_templates.json:1546: If this policy is left not set the global default value will be used for all sites either from the 'DefaultPopupsSetting' policy or what the user has chosen if it is not set too.''', same. http://codereview.chromium.org/8465017/diff/1/chrome/app/policy/policy_templa... chrome/app/policy/policy_templates.json:1558: If this policy is left not set the global default value will be used for all sites either from the 'DefaultPopupsSetting' policy or what the user has chosen if it is not set too.''', same. http://codereview.chromium.org/8465017/diff/1/chrome/app/policy/policy_templa... chrome/app/policy/policy_templates.json:1570: If this policy is left not set the global default value will be used for all sites either from the 'DefaultNotificationsSetting' policy or what the user has chosen if it is not set too.''', same. http://codereview.chromium.org/8465017/diff/1/chrome/app/policy/policy_templa... chrome/app/policy/policy_templates.json:1582: If this policy is left not set the global default value will be used for all sites either from the 'DefaultNotificationsSetting' policy or what the user has chosen if it is not set too.''', same. http://codereview.chromium.org/8465017/diff/1/chrome/app/policy/policy_templa... chrome/app/policy/policy_templates.json:1644: The default setting used when this option is left not set is to allow the host browser do the rendering, but you option -> policy http://codereview.chromium.org/8465017/diff/1/chrome/app/policy/policy_templa... chrome/app/policy/policy_templates.json:1658: If this option is not set the default renderer will be used for all sites as specified by the 'ChromeFrameRendererSettings' policy. option -> policy http://codereview.chromium.org/8465017/diff/1/chrome/app/policy/policy_templa... chrome/app/policy/policy_templates.json:1672: If this option is not set the default renderer will be used for all sites as specified by the 'ChromeFrameRendererSettings' policy. option -> policy http://codereview.chromium.org/8465017/diff/1/chrome/app/policy/policy_templa... chrome/app/policy/policy_templates.json:1694: If this option is not set the default renderer will be used for all sites as specified by the 'ChromeFrameRendererSettings' policy.''', option -> policy http://codereview.chromium.org/8465017/diff/1/chrome/app/policy/policy_templa... chrome/app/policy/policy_templates.json:1714: If the option is left not set the user can choose whether he wants to be asked for password to unlock the device or not.''', option -> policy http://codereview.chromium.org/8465017/diff/1/chrome/app/policy/policy_templa... chrome/app/policy/policy_templates.json:1900: If it is not set, the default behaviour is used which is to ask the user.''', If it is not set, the user may be asked whether to import, or importing may happen automatically. http://codereview.chromium.org/8465017/diff/1/chrome/app/policy/policy_templa... chrome/app/policy/policy_templates.json:1915: If it is not set, the default behavior is used which is to ask the user.''', If it is not set, the user may be asked whether to import, or importing may happen automatically. http://codereview.chromium.org/8465017/diff/1/chrome/app/policy/policy_templa... chrome/app/policy/policy_templates.json:1930: If it is not set, the default behavior is used which is to ask the user.''', If it is not set, the user may be asked whether to import, or importing may happen automatically. http://codereview.chromium.org/8465017/diff/1/chrome/app/policy/policy_templa... chrome/app/policy/policy_templates.json:1945: If it is not set, the default behavior is used which is to ask the user.''', If it is not set, the user may be asked whether to import, or importing may happen automatically. http://codereview.chromium.org/8465017/diff/1/chrome/app/policy/policy_templa... chrome/app/policy/policy_templates.json:1960: If it is not set, the default behavior is used which is to ask the user.''', If it is not set, the user may be asked whether to import, or importing may happen automatically. http://codereview.chromium.org/8465017/diff/1/chrome/app/policy/policy_templa... chrome/app/policy/policy_templates.json:1979: If this policy is left not set the default value will be used which is 32. This value might change in future versions of <ph name="PRODUCT_FRAME_NAME">$3<ex>Google Chrome Frame</ex></ph>.''', can we just say "the current default value which is 32" -- no need to say that this may change in the future, as that is always possible :)
Thanks for going through this rather lengthy list. I feel my English enriched after this review :). http://codereview.chromium.org/8465017/diff/1/chrome/app/policy/policy_templa... File chrome/app/policy/policy_templates.json (right): http://codereview.chromium.org/8465017/diff/1/chrome/app/policy/policy_templa... chrome/app/policy/policy_templates.json:214: If this policy is left not set the default value will be used which is enabled and the user will be able to change it.''', On 2011/11/10 19:54:23, Glenn Wilson wrote: > a little awkward. How about: > > If this policy is left not set, this will be enabled but the user will be able > to change it. Done. http://codereview.chromium.org/8465017/diff/1/chrome/app/policy/policy_templa... chrome/app/policy/policy_templates.json:232: If this policy is left not set the default value will be used which is enabled and the user will be able to change it.''', On 2011/11/10 19:54:23, Glenn Wilson wrote: > Same here, how about: > > If this policy is left not set, this will be enabled but the user will be able > to change it. Done. http://codereview.chromium.org/8465017/diff/1/chrome/app/policy/policy_templa... chrome/app/policy/policy_templates.json:246: If this policy is left not set the default value will be used which is enabled and the user will be able to change it.''', On 2011/11/10 19:54:23, Glenn Wilson wrote: > same here. Done. http://codereview.chromium.org/8465017/diff/1/chrome/app/policy/policy_templa... chrome/app/policy/policy_templates.json:262: If this policy is left not set the default value will be used which is disabled and the user will be able to change it.''', On 2011/11/10 19:54:23, Glenn Wilson wrote: > same here. Changed a bit beacuse this one is actually disabled by default but given the negatrive name it is a bit vagues so now it reads: If this policy is left not set, SPDY will be available but the user will be able to change it. http://codereview.chromium.org/8465017/diff/1/chrome/app/policy/policy_templa... chrome/app/policy/policy_templates.json:296: If this policy is left not set the default value will be used which is enabled and the user will be able to change it. On 2011/11/10 19:54:23, Glenn Wilson wrote: > same here. Done. http://codereview.chromium.org/8465017/diff/1/chrome/app/policy/policy_templa... chrome/app/policy/policy_templates.json:316: If this policy is left not set the default value will be used which is enabled and the user will be able to use incognito mode.''', On 2011/11/10 19:54:23, Glenn Wilson wrote: > Same here. How about: > > If this policy is left not set, this will be enabled and the user will be able > to use incognito mode. Done. http://codereview.chromium.org/8465017/diff/1/chrome/app/policy/policy_templa... chrome/app/policy/policy_templates.json:404: If this policy is left not set the default value will be used which is enabled.''', On 2011/11/10 19:54:23, Glenn Wilson wrote: > How about: > > If this policy is left not set the setting will be enabled. Done. http://codereview.chromium.org/8465017/diff/1/chrome/app/policy/policy_templa... chrome/app/policy/policy_templates.json:422: If this policy is left not set the default value will be used which is enabled and the user will be able to change it.''', On 2011/11/10 19:54:23, Glenn Wilson wrote: > same here. Done. http://codereview.chromium.org/8465017/diff/1/chrome/app/policy/policy_templa... chrome/app/policy/policy_templates.json:439: If this policy is left not set the default value will be used which is enabled and the user will be able to change it.''', On 2011/11/10 19:54:23, Glenn Wilson wrote: > same Done. http://codereview.chromium.org/8465017/diff/1/chrome/app/policy/policy_templa... chrome/app/policy/policy_templates.json:457: If this policy is left not set the default value will be used which is enabled and the user will be able to change it.''', On 2011/11/10 19:54:23, Glenn Wilson wrote: > same. Done. http://codereview.chromium.org/8465017/diff/1/chrome/app/policy/policy_templa... chrome/app/policy/policy_templates.json:475: If this policy is left not set the default value chosen upon installation will be used which is enabled and the user will be able to change it.''', On 2011/11/10 19:54:23, Glenn Wilson wrote: > Awkward. Maybe: > > If this policy is left not set the setting will be what the user chose upon > installation / first run. Done. http://codereview.chromium.org/8465017/diff/1/chrome/app/policy/policy_templa... chrome/app/policy/policy_templates.json:499: If this policy is left not set the default value will be used which is enabled and the user will be able to change it.''', On 2011/11/10 19:54:23, Glenn Wilson wrote: > same here. Done. http://codereview.chromium.org/8465017/diff/1/chrome/app/policy/policy_templa... chrome/app/policy/policy_templates.json:613: If this policy is left not set synchronization will be available for the user to choose whether to use it or not.''', On 2011/11/10 19:54:23, Glenn Wilson wrote: > synchronization --> Google Sync Done. http://codereview.chromium.org/8465017/diff/1/chrome/app/policy/policy_templa... chrome/app/policy/policy_templates.json:672: If set to disabled side data will not be cleared on exit. On 2011/11/10 19:54:23, Glenn Wilson wrote: > side data -> site data Done. http://codereview.chromium.org/8465017/diff/1/chrome/app/policy/policy_templa... chrome/app/policy/policy_templates.json:866: If this policy is left unset the default will be used which is using all four schemes.''', On 2011/11/10 19:54:23, Glenn Wilson wrote: > If this policy is left not set, all four schemes will be used. Done. http://codereview.chromium.org/8465017/diff/1/chrome/app/policy/policy_templa... chrome/app/policy/policy_templates.json:944: Typically this is disabled (which is also the case if this policy is not set) as a phishing defense.''', On 2011/11/10 19:54:23, Glenn Wilson wrote: > How about leaving the previous sentence as-is and appending another, as so: > > Typically this is disabled as a phishing defense. If this policy is not set, > this is disabled and third-party sub-content will not be allowed to pop up a > HTTP Basic Auth dialog box. Done. http://codereview.chromium.org/8465017/diff/1/chrome/app/policy/policy_templa... chrome/app/policy/policy_templates.json:966: If this policy is left not set the user can install any extension on the system.''', On 2011/11/10 19:54:23, Glenn Wilson wrote: > (probably don't need 'on the system') Changed "the system" to "in Chrome". http://codereview.chromium.org/8465017/diff/1/chrome/app/policy/policy_templa... chrome/app/policy/policy_templates.json:998: If this policy is left not set the user can uninstall any extension on the system.''', On 2011/11/10 19:54:23, Glenn Wilson wrote: > (probably don't need 'on the system') The same here. http://codereview.chromium.org/8465017/diff/1/chrome/app/policy/policy_templa... chrome/app/policy/policy_templates.json:1019: Leaving this policy not set will allow the user to choose whether to show the home button on his own.''', On 2011/11/10 19:54:23, Glenn Wilson wrote: > probably don't need 'on his own' Done. http://codereview.chromium.org/8465017/diff/1/chrome/app/policy/policy_templa... chrome/app/policy/policy_templates.json:1108: If this policy is left not set the default value will be used which is disabled and the user will be able to change it.''', On 2011/11/10 19:54:23, Glenn Wilson wrote: > same here. Again negative policy so what about this one: If this policy is left not set, third party cookies will be enabled but the user will be able to change that. http://codereview.chromium.org/8465017/diff/1/chrome/app/policy/policy_templa... chrome/app/policy/policy_templates.json:1134: If this policy is left not set the default value will be used which is enabled and the user will be able to set his search provider list.''', On 2011/11/10 19:54:23, Glenn Wilson wrote: > If this policy is left not set, the default search provider is enabled, and the > user will be able to set the search provider list. Done. http://codereview.chromium.org/8465017/diff/1/chrome/app/policy/policy_templa... chrome/app/policy/policy_templates.json:1158: This policy is optional if not set no keyword will activate the search provider. On 2011/11/10 19:54:23, Glenn Wilson wrote: > This policy is optional. If not set, no keyword will activate the search > provider. Done. http://codereview.chromium.org/8465017/diff/1/chrome/app/policy/policy_templa... chrome/app/policy/policy_templates.json:1172: This option must not be left not set when the 'DefaultSearchProviderEnabled' policy is enabled and will only be considered if this is the case.''', On 2011/11/10 19:54:23, Glenn Wilson wrote: > This option must be set when... > > ...and will only be respected if... Done. http://codereview.chromium.org/8465017/diff/1/chrome/app/policy/policy_templa... chrome/app/policy/policy_templates.json:1184: This policy is optional if not set no suggest URL will be used. On 2011/11/10 19:54:23, Glenn Wilson wrote: > This policy is optional. If not set, no suggest URL will be used. Done. http://codereview.chromium.org/8465017/diff/1/chrome/app/policy/policy_templa... chrome/app/policy/policy_templates.json:1186: This policy is only considered if the 'DefaultSearchProviderEnabled' policy is enabled.''', On 2011/11/10 19:54:23, Glenn Wilson wrote: > considered -> respected Done. http://codereview.chromium.org/8465017/diff/1/chrome/app/policy/policy_templa... chrome/app/policy/policy_templates.json:1198: This policy is optional if not set no instant search results will be provided. On 2011/11/10 19:54:23, Glenn Wilson wrote: > This policy is optional. If not set, no instant search results will be > provided. Done. http://codereview.chromium.org/8465017/diff/1/chrome/app/policy/policy_templa... chrome/app/policy/policy_templates.json:1200: This policy is only considered if the 'DefaultSearchProviderEnabled' policy is enabled.''', On 2011/11/10 19:54:23, Glenn Wilson wrote: > considered -> respected Done. http://codereview.chromium.org/8465017/diff/1/chrome/app/policy/policy_templa... chrome/app/policy/policy_templates.json:1212: This policy is optional if not set no icon will be present for the search provider. On 2011/11/10 19:54:23, Glenn Wilson wrote: > same here. New sentence after 'optional' Done. http://codereview.chromium.org/8465017/diff/1/chrome/app/policy/policy_templa... chrome/app/policy/policy_templates.json:1214: This policy is only considered if the 'DefaultSearchProviderEnabled' policy is enabled.''', On 2011/11/10 19:54:23, Glenn Wilson wrote: > considered -> respected Done. http://codereview.chromium.org/8465017/diff/1/chrome/app/policy/policy_templa... chrome/app/policy/policy_templates.json:1226: This policy is optional if not set the default will be used which is UTF-8. On 2011/11/10 19:54:23, Glenn Wilson wrote: > This policy is optional. If not set, UTF-8 is used. Done. http://codereview.chromium.org/8465017/diff/1/chrome/app/policy/policy_templa... chrome/app/policy/policy_templates.json:1228: This policy is only considered if the 'DefaultSearchProviderEnabled' policy is enabled.''', On 2011/11/10 19:54:23, Glenn Wilson wrote: > considered -> respected Done. http://codereview.chromium.org/8465017/diff/1/chrome/app/policy/policy_templa... chrome/app/policy/policy_templates.json:1260: If this policy is left not set the default value will be used which is 'AllowCookies' and the user will be able to change it.''', On 2011/11/10 19:54:23, Glenn Wilson wrote: > If this policy is left not set, 'AllowCookies' will be used and the user will be > able to change it. Done. http://codereview.chromium.org/8465017/diff/1/chrome/app/policy/policy_templa... chrome/app/policy/policy_templates.json:1284: If this policy is left not set the default value will be used which is 'AllowImages' and the user will be able to change it.''', On 2011/11/10 19:54:23, Glenn Wilson wrote: > If this policy is left not set, 'AllowImages' will be used and the user will be > able to change it. Done. http://codereview.chromium.org/8465017/diff/1/chrome/app/policy/policy_templa... chrome/app/policy/policy_templates.json:1308: If this policy is left not set the default value will be used which is 'AllowJavaScript' and the user will be able to change it.''', On 2011/11/10 19:54:23, Glenn Wilson wrote: > If this policy is left not set, 'AllowJavaScript' will be used and the user will > be able to change it. Done. http://codereview.chromium.org/8465017/diff/1/chrome/app/policy/policy_templa... chrome/app/policy/policy_templates.json:1332: If this policy is left not set the default value will be used which is 'AllowPlugins' and the user will be able to change it.''', On 2011/11/10 19:54:23, Glenn Wilson wrote: > If this policy is left not set, 'AllowPlugins' will be used and the user will be > able to change it. Done. http://codereview.chromium.org/8465017/diff/1/chrome/app/policy/policy_templa... chrome/app/policy/policy_templates.json:1356: If this policy is left not set the default value will be used which is 'BlockPopups' and the user will be able to change it.''', On 2011/11/10 19:54:23, Glenn Wilson wrote: > If this policy is left not set, 'BlockPopups' will be used and the user will be > able to change it. Done. http://codereview.chromium.org/8465017/diff/1/chrome/app/policy/policy_templa... chrome/app/policy/policy_templates.json:1385: If this policy is left not set the default value will be used which is 'AskNotifications' and the user will be able to change it.''', On 2011/11/10 19:54:23, Glenn Wilson wrote: > If this policy is left not set, 'AskNotifications' will be used and the user > will be able to change it. Done. http://codereview.chromium.org/8465017/diff/1/chrome/app/policy/policy_templa... chrome/app/policy/policy_templates.json:1414: If this policy is left not set the default value will be used which is 'AskGeolocation' and the user will be able to change it.''', On 2011/11/10 19:54:23, Glenn Wilson wrote: > If this policy is left not set, 'AskGeolocation' will be used and the user will > be able to change it. Done. http://codereview.chromium.org/8465017/diff/1/chrome/app/policy/policy_templa... chrome/app/policy/policy_templates.json:1438: If this policy is left not set the global default value will be used for all sites either from the 'DefaultCookiesSetting' policy or what the user has chosen if it is not set too.''', On 2011/11/10 19:54:23, Glenn Wilson wrote: > can we change this to > > ...all sites either from the 'DefaultCookiesSetting' policy if it is set, or the > user's personal configuration otherwise. Done. http://codereview.chromium.org/8465017/diff/1/chrome/app/policy/policy_templa... chrome/app/policy/policy_templates.json:1450: If this policy is left not set the global default value will be used for all sites either from the 'DefaultCookiesSetting' policy or what the user has chosen if it is not set too.''', On 2011/11/10 19:54:23, Glenn Wilson wrote: > same here Done. http://codereview.chromium.org/8465017/diff/1/chrome/app/policy/policy_templa... chrome/app/policy/policy_templates.json:1462: If this policy is left not set the global default value will be used for all sites either from the 'DefaultCookiesSetting' policy or what the user has chosen if it is not set too.''', On 2011/11/10 19:54:23, Glenn Wilson wrote: > same Done. http://codereview.chromium.org/8465017/diff/1/chrome/app/policy/policy_templa... chrome/app/policy/policy_templates.json:1474: If this policy is left not set the global default value will be used for all sites either from the 'DefaultImagesSetting' policy or what the user has chosen if it is not set too.''', On 2011/11/10 19:54:23, Glenn Wilson wrote: > same Done. http://codereview.chromium.org/8465017/diff/1/chrome/app/policy/policy_templa... chrome/app/policy/policy_templates.json:1486: If this policy is left not set the global default value will be used for all sites either from the 'DefaultImagesSetting' policy or what the user has chosen if it is not set too.''', On 2011/11/10 19:54:23, Glenn Wilson wrote: > same. Done. http://codereview.chromium.org/8465017/diff/1/chrome/app/policy/policy_templa... chrome/app/policy/policy_templates.json:1498: If this policy is left not set the global default value will be used for all sites either from the 'DefaultJavaScriptSetting' policy or what the user has chosen if it is not set too.''', On 2011/11/10 19:54:23, Glenn Wilson wrote: > same Done. http://codereview.chromium.org/8465017/diff/1/chrome/app/policy/policy_templa... chrome/app/policy/policy_templates.json:1510: If this policy is left not set the global default value will be used for all sites either from the 'DefaultJavaScriptSetting' policy or what the user has chosen if it is not set too.''', On 2011/11/10 19:54:23, Glenn Wilson wrote: > same. Done. http://codereview.chromium.org/8465017/diff/1/chrome/app/policy/policy_templa... chrome/app/policy/policy_templates.json:1522: If this policy is left not set the global default value will be used for all sites either from the 'DefaultPluginsSetting' policy or what the user has chosen if it is not set too.''', On 2011/11/10 19:54:23, Glenn Wilson wrote: > same Done. http://codereview.chromium.org/8465017/diff/1/chrome/app/policy/policy_templa... chrome/app/policy/policy_templates.json:1534: If this policy is left not set the global default value will be used for all sites either from the 'DefaultPluginsSetting' policy or what the user has chosen if it is not set too.''', On 2011/11/10 19:54:23, Glenn Wilson wrote: > same. Done. http://codereview.chromium.org/8465017/diff/1/chrome/app/policy/policy_templa... chrome/app/policy/policy_templates.json:1546: If this policy is left not set the global default value will be used for all sites either from the 'DefaultPopupsSetting' policy or what the user has chosen if it is not set too.''', On 2011/11/10 19:54:23, Glenn Wilson wrote: > same. Done. http://codereview.chromium.org/8465017/diff/1/chrome/app/policy/policy_templa... chrome/app/policy/policy_templates.json:1558: If this policy is left not set the global default value will be used for all sites either from the 'DefaultPopupsSetting' policy or what the user has chosen if it is not set too.''', On 2011/11/10 19:54:23, Glenn Wilson wrote: > same. Done. http://codereview.chromium.org/8465017/diff/1/chrome/app/policy/policy_templa... chrome/app/policy/policy_templates.json:1570: If this policy is left not set the global default value will be used for all sites either from the 'DefaultNotificationsSetting' policy or what the user has chosen if it is not set too.''', On 2011/11/10 19:54:23, Glenn Wilson wrote: > same. Done. http://codereview.chromium.org/8465017/diff/1/chrome/app/policy/policy_templa... chrome/app/policy/policy_templates.json:1582: If this policy is left not set the global default value will be used for all sites either from the 'DefaultNotificationsSetting' policy or what the user has chosen if it is not set too.''', On 2011/11/10 19:54:23, Glenn Wilson wrote: > same. Done. http://codereview.chromium.org/8465017/diff/1/chrome/app/policy/policy_templa... chrome/app/policy/policy_templates.json:1644: The default setting used when this option is left not set is to allow the host browser do the rendering, but you On 2011/11/10 19:54:23, Glenn Wilson wrote: > option -> policy Done. http://codereview.chromium.org/8465017/diff/1/chrome/app/policy/policy_templa... chrome/app/policy/policy_templates.json:1658: If this option is not set the default renderer will be used for all sites as specified by the 'ChromeFrameRendererSettings' policy. On 2011/11/10 19:54:23, Glenn Wilson wrote: > option -> policy Done. http://codereview.chromium.org/8465017/diff/1/chrome/app/policy/policy_templa... chrome/app/policy/policy_templates.json:1672: If this option is not set the default renderer will be used for all sites as specified by the 'ChromeFrameRendererSettings' policy. On 2011/11/10 19:54:23, Glenn Wilson wrote: > option -> policy Done. http://codereview.chromium.org/8465017/diff/1/chrome/app/policy/policy_templa... chrome/app/policy/policy_templates.json:1694: If this option is not set the default renderer will be used for all sites as specified by the 'ChromeFrameRendererSettings' policy.''', On 2011/11/10 19:54:23, Glenn Wilson wrote: > option -> policy Done. http://codereview.chromium.org/8465017/diff/1/chrome/app/policy/policy_templa... chrome/app/policy/policy_templates.json:1714: If the option is left not set the user can choose whether he wants to be asked for password to unlock the device or not.''', On 2011/11/10 19:54:23, Glenn Wilson wrote: > option -> policy Done. http://codereview.chromium.org/8465017/diff/1/chrome/app/policy/policy_templa... chrome/app/policy/policy_templates.json:1900: If it is not set, the default behaviour is used which is to ask the user.''', On 2011/11/10 19:54:23, Glenn Wilson wrote: > If it is not set, the user may be asked whether to import, or importing may > happen automatically. Done. http://codereview.chromium.org/8465017/diff/1/chrome/app/policy/policy_templa... chrome/app/policy/policy_templates.json:1915: If it is not set, the default behavior is used which is to ask the user.''', On 2011/11/10 19:54:23, Glenn Wilson wrote: > If it is not set, the user may be asked whether to import, or importing may > happen automatically. Done. http://codereview.chromium.org/8465017/diff/1/chrome/app/policy/policy_templa... chrome/app/policy/policy_templates.json:1930: If it is not set, the default behavior is used which is to ask the user.''', On 2011/11/10 19:54:23, Glenn Wilson wrote: > If it is not set, the user may be asked whether to import, or importing may > happen automatically. Done. http://codereview.chromium.org/8465017/diff/1/chrome/app/policy/policy_templa... chrome/app/policy/policy_templates.json:1945: If it is not set, the default behavior is used which is to ask the user.''', On 2011/11/10 19:54:23, Glenn Wilson wrote: > If it is not set, the user may be asked whether to import, or importing may > happen automatically. Done. http://codereview.chromium.org/8465017/diff/1/chrome/app/policy/policy_templa... chrome/app/policy/policy_templates.json:1960: If it is not set, the default behavior is used which is to ask the user.''', On 2011/11/10 19:54:23, Glenn Wilson wrote: > If it is not set, the user may be asked whether to import, or importing may > happen automatically. Done. http://codereview.chromium.org/8465017/diff/1/chrome/app/policy/policy_templa... chrome/app/policy/policy_templates.json:1979: If this policy is left not set the default value will be used which is 32. This value might change in future versions of <ph name="PRODUCT_FRAME_NAME">$3<ex>Google Chrome Frame</ex></ph>.''', On 2011/11/10 19:54:23, Glenn Wilson wrote: > can we just say "the current default value which is 32" -- no need to say that > this may change in the future, as that is always possible :) Sure. I write it here because this value is actually part of ongoing filed trial whether 32 or 16 or 64 is better and it might change really soon or even be different for users that fall into the test buckets.
LGTM Thanks for taking on such a large set of changes!
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pastarmovj@chromium.org/8465017/5001
rubberstamp LGTM
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pastarmovj@chromium.org/8465017/5001
Change committed as 110292 |
