Issue 8463031: Disk cache: Simplyfy some of the test infrastructure.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8463031: Disk cache: Simplyfy some of the test infrastructure. (Closed)

Created:
9 years, 1 month ago by rvargas (doing something else)

Modified:
9 years, 1 month ago

Reviewers:
gavinp

CC:
chromium-reviews, cbentzel+watch_chromium.org, darin-cc_chromium.org, Paweł Hajdan Jr.

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Disk cache: Simplify some of the test infrastructure. BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=110192

Created: 9 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+117 lines, -115 lines)			Patch
M	net/disk_cache/backend_unittest.cc	View		14 chunks	+16 lines, -23 lines	0 comments	Download
M	net/disk_cache/block_files_unittest.cc	View		9 chunks	+25 lines, -33 lines	0 comments	Download
M	net/disk_cache/disk_cache_perftest.cc	View		6 chunks	+12 lines, -18 lines	0 comments	Download
M	net/disk_cache/disk_cache_test_base.h	View	1 2 3	3 chunks	+18 lines, -3 lines	0 comments	Download
M	net/disk_cache/disk_cache_test_base.cc	View	1 2	7 chunks	+37 lines, -12 lines	0 comments	Download
M	net/disk_cache/disk_cache_test_util.h	View		2 chunks	+1 line, -4 lines	0 comments	Download
M	net/disk_cache/disk_cache_test_util.cc	View		2 chunks	+1 line, -15 lines	0 comments	Download
M	net/disk_cache/mapped_file_unittest.cc	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	net/disk_cache/storage_block_unittest.cc	View		3 chunks	+3 lines, -3 lines	0 comments	Download
M	net/net.gyp	View	1	2 chunks	+2 lines, -2 lines	0 comments	Download

Total messages: 2 (0 generated)

lgtm

LGTM, I like this a lot.