Issue 8463024: Implement CompositorCC::ReadPixels

Issue 8463024: Implement CompositorCC::ReadPixels (Closed)

Created:
9 years, 1 month ago by Ian Vollick

Modified:
9 years, 1 month ago

Reviewers:
vollick1, piman, jonathan.backer

CC:
chromium-reviews, piman+watch_chromium.org, Paweł Hajdan Jr., jonathan.backer

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Implement CompositorCC::ReadPixels Depends on https://bugs.webkit.org/show_bug.cgi?id=72188 I've refactored backer's swizzle/flip code as it was needed by compositor_cc as well as compositor_gl. BUG=None TEST=compositor_unittests Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=110174

Patch Set 1 #

Patch Set 2 : Minor interface change to compositeAndReadback #

Patch Set 3 : Compositor::ReadPixels now returns bool #

Total comments: 3

Patch Set 4 : Address reviewer comments. #

Patch Set 5 : Minor host API change. #

Created: 9 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+75 lines, -30 lines)			Patch
M	ui/gfx/compositor/compositor.h	View	1 2 3	2 chunks	+7 lines, -1 line	0 comments	Download
M	ui/gfx/compositor/compositor.cc	View		1 chunk	+23 lines, -0 lines	0 comments	Download
M	ui/gfx/compositor/compositor_cc.h	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
M	ui/gfx/compositor/compositor_cc.cc	View	1 2 3 4	2 chunks	+14 lines, -2 lines	0 comments	Download
M	ui/gfx/compositor/compositor_gl.h	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
M	ui/gfx/compositor/compositor_gl.cc	View	1 2	2 chunks	+3 lines, -20 lines	0 comments	Download
M	ui/gfx/compositor/compositor_win.cc	View	1 2	2 chunks	+3 lines, -2 lines	0 comments	Download
M	ui/gfx/compositor/layer_unittest.cc	View	1 2 3	3 chunks	+20 lines, -1 line	0 comments	Download
M	ui/gfx/compositor/test_compositor.h	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
M	ui/gfx/compositor/test_compositor.cc	View	1 2	1 chunk	+2 lines, -1 line	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

jonathan.backer

LGTM with nits. Thanks for doing this. http://codereview.chromium.org/8463024/diff/5001/ui/gfx/compositor/compositor.h File ui/gfx/compositor/compositor.h (right): http://codereview.chromium.org/8463024/diff/5001/ui/gfx/compositor/compositor.h#newcode181 ui/gfx/compositor/compositor.h:181: void SwizzleRGBAToBGRAAndFlip(unsigned ...

9 years, 1 month ago (2011-11-14 14:06:58 UTC) #3

Ian Vollick

On 2011/11/14 14:06:58, jonathan.backer wrote: > LGTM with nits. > > Thanks for doing this. ...

9 years, 1 month ago (2011-11-14 14:48:30 UTC) #4

piman

LGTM. Do you think we can land this soon? I believe the WebKit side is ...

9 years, 1 month ago (2011-11-15 21:11:48 UTC) #5

vollick1

9 years, 1 month ago (2011-11-15 21:28:16 UTC) #6

Yes, I hope to land it this afternoon.

On Tue, Nov 15, 2011 at 4:11 PM, <piman@chromium.org> wrote:

> LGTM. Do you think we can land this soon? I believe the WebKit side is in,
> right?
>
>
http://codereview.chromium.**org/8463024/<http://codereview.chromium.org/8463...
>

Expand Messages | Collapse Messages