Issue 8463009: Cleanup: Remove unneeded forward declarations from chrome/browser/ui/views.

Issue 8463009: Cleanup: Remove unneeded forward declarations from chrome/browser/ui/views. (Closed)

Created:
9 years, 1 month ago by Lei Zhang

Modified:
9 years, 1 month ago

Reviewers:
sky

CC:
chromium-reviews, asanka, msw+watch_chromium.org, Erik does not do reviews, mihaip+watch_chromium.org, Randy Smith (Not in Mondays), Aaron Boodman, alicet1

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Cleanup: Remove unneeded forward declarations from chrome/browser/ui/views. BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=110049

Patch Set 2 : rebase, no code change #

Created: 9 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9 lines, -84 lines)			Patch
M	chrome/browser/ui/views/about_ipc_dialog.h	View	1	1 chunk	+0 lines, -2 lines	0 comments	Download
M	chrome/browser/ui/views/autocomplete/autocomplete_popup_contents_view.h	View	1	1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/browser/ui/views/bookmarks/bookmark_bar_view.h	View	1	2 chunks	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/views/bookmarks/bookmark_menu_controller_views.h	View	1	1 chunk	+0 lines, -4 lines	0 comments	Download
M	chrome/browser/ui/views/browser_actions_container.h	View	1	1 chunk	+0 lines, -4 lines	0 comments	Download
M	chrome/browser/ui/views/bubble/bubble.h	View	1	1 chunk	+0 lines, -4 lines	0 comments	Download
M	chrome/browser/ui/views/database_info_view.h	View	1	2 chunks	+1 line, -2 lines	0 comments	Download
M	chrome/browser/ui/views/default_search_view.h	View	1	2 chunks	+0 lines, -2 lines	0 comments	Download
M	chrome/browser/ui/views/detachable_toolbar_view.h	View	1	1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/browser/ui/views/download/download_shelf_view.h	View	1	2 chunks	+2 lines, -1 line	0 comments	Download
M	chrome/browser/ui/views/edit_search_engine_dialog.h	View	1	1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/browser/ui/views/extensions/browser_action_drag_data.h	View	1	2 chunks	+1 line, -3 lines	0 comments	Download
M	chrome/browser/ui/views/extensions/extension_dialog.h	View	1	1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/browser/ui/views/extensions/extension_popup.h	View	1	1 chunk	+0 lines, -5 lines	0 comments	Download
M	chrome/browser/ui/views/frame/app_panel_browser_frame_view.h	View	1	1 chunk	+0 lines, -2 lines	0 comments	Download
M	chrome/browser/ui/views/frame/browser_frame.h	View	1	1 chunk	+0 lines, -2 lines	0 comments	Download
M	chrome/browser/ui/views/frame/browser_frame_gtk.h	View	1	1 chunk	+0 lines, -3 lines	0 comments	Download
M	chrome/browser/ui/views/frame/browser_non_client_frame_view_aura.h	View	1	1 chunk	+0 lines, -7 lines	0 comments	Download
M	chrome/browser/ui/views/frame/browser_view.h	View	1	1 chunk	+0 lines, -2 lines	0 comments	Download
M	chrome/browser/ui/views/frame/glass_browser_frame_view.h	View	1	1 chunk	+0 lines, -2 lines	0 comments	Download
M	chrome/browser/ui/views/frame/opaque_browser_frame_view.h	View	1	1 chunk	+0 lines, -5 lines	0 comments	Download
M	chrome/browser/ui/views/indexed_db_info_view.h	View	1	2 chunks	+1 line, -2 lines	0 comments	Download
M	chrome/browser/ui/views/infobars/extension_infobar.h	View	1	1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/browser/ui/views/local_storage_info_view.h	View	1	3 chunks	+1 line, -3 lines	0 comments	Download
M	chrome/browser/ui/views/local_storage_set_item_info_view.h	View	1	3 chunks	+1 line, -3 lines	0 comments	Download
M	chrome/browser/ui/views/location_bar/location_bar_view.h	View	1	1 chunk	+0 lines, -6 lines	0 comments	Download
M	chrome/browser/ui/views/notifications/balloon_view.h	View	1	1 chunk	+0 lines, -2 lines	0 comments	Download
M	chrome/browser/ui/views/page_info_bubble_view.h	View	1	1 chunk	+0 lines, -4 lines	0 comments	Download
M	chrome/browser/ui/views/repost_form_warning_view.h	View	1	1 chunk	+0 lines, -2 lines	0 comments	Download
M	chrome/browser/ui/views/sad_tab_view.h	View	1	1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/browser/ui/views/tab_icon_view.h	View	1	2 chunks	+1 line, -2 lines	0 comments	Download
M	chrome/browser/ui/views/tabs/tab.h	View	1	1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/browser/ui/views/toolbar_view.h	View	1	2 chunks	+0 lines, -2 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thestig@chromium.org/8463009/1

9 years, 1 month ago (2011-11-11 19:47:04 UTC) #3

commit-bot: I haz the power

Can't apply patch for file chrome/browser/ui/views/bookmarks/bookmark_bubble_view.h. While running patch -p0 --forward --force; patching file chrome/browser/ui/views/bookmarks/bookmark_bubble_view.h ...

9 years, 1 month ago (2011-11-11 20:58:37 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thestig@chromium.org/8463009/5009

9 years, 1 month ago (2011-11-11 21:01:45 UTC) #5

commit-bot: I haz the power

9 years, 1 month ago (2011-11-11 22:56:03 UTC) #6

Try job failure for 8463009-5009 (retry) on win_rel for step "ui_tests".
It's a second try, previously, step "ui_tests" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

Expand Messages | Collapse Messages