A couple comment updates

base/threading/worker_pool_posix.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/threading/worker_pool_posix.h"
 
 #include "base/bind.h"
 #include "base/debug/trace_event.h"
 #include "base/lazy_instance.h"
 #include "base/logging.h"
 #include "base/memory/ref_counted.h"
-#include "base/stringprintf.h"
+#include "base/string_number_conversions.h"
 #include "base/task.h"
 #include "base/threading/platform_thread.h"
 #include "base/threading/worker_pool.h"
 #include "base/tracked_objects.h"
 
 namespace base {
 
 namespace {
 
 const int kIdleSecondsBeforeExit = 10 * 60;
@@ skipping 33 matching lines @@
                               const base::Closure& task, bool task_is_slow) {
   pool_->PostTask(from_here, task);
 }
 
 base::LazyInstance<WorkerPoolImpl> g_lazy_worker_pool(base::LINKER_INITIALIZED);
 
 class WorkerThread : public PlatformThread::Delegate {
  public:
   WorkerThread(const std::string& name_prefix,
                base::PosixDynamicThreadPool* pool)
-      : name_prefix_(name_prefix),
+      : name_(name_prefix),
         pool_(pool) {}
 
   virtual void ThreadMain();
 
  private:
-  const std::string name_prefix_;
+  std::string name_;
   scoped_refptr<base::PosixDynamicThreadPool> pool_;
 
   DISALLOW_COPY_AND_ASSIGN(WorkerThread);
 };
 
 void WorkerThread::ThreadMain() {
-  const std::string name = base::StringPrintf(
-      "%s/%d", name_prefix_.c_str(), PlatformThread::CurrentId());
-  PlatformThread::SetName(name.c_str());
+  name_.reserve(name_.size() + 10);

[jar (doing other things), 2011/11/04 15:30:32]

nit: Reserve is not needed.

[joth, 2011/11/04 16:41:25]

will remove

+  name_.push_back('/');
+  name_.append(IntToString(PlatformThread::CurrentId()));
+  PlatformThread::SetName(name_.c_str());
 
   for (;;) {
     PosixDynamicThreadPool::PendingTask pending_task = pool_->WaitForTask();
     if (pending_task.task.is_null())
       break;
     UNSHIPPED_TRACE_EVENT2("task", "WorkerThread::ThreadMain::Run",
         "src_file", pending_task.posted_from.file_name(),
         "src_func", pending_task.posted_from.function_name());
 
     tracked_objects::TrackedTime start_time =
@@ skipping 125 matching lines @@
       return PendingTask(FROM_HERE, base::Closure());
     }
   }
 
   PendingTask pending_task = pending_tasks_.front();
   pending_tasks_.pop();
   return pending_task;
 }
 
 }  // namespace base