Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(248)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 8462009: WebUI TaskManager: Add "Activate page" feature. (Closed)

Created:
9 years, 1 month ago by yoshiki
Modified:
9 years, 1 month ago
Reviewers:
mazda
CC:
chromium-reviews, arv (Not doing code reviews), yoshiki+watch_chromium.org
Visibility:
Public.

Description

WebUI TaskManager: Add "Activate page" feature. We can activate a page by double-clicking on the page or the context-menu. BUG=103345 TEST=manual Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=109434

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+111 lines, -34 lines) Patch
M chrome/app/generated_resources.grd View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/resources/task_manager/main.js View 8 chunks +71 lines, -34 lines 0 comments Download
M chrome/browser/task_manager/task_manager.h View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/task_manager/task_manager.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M chrome/browser/ui/webui/task_manager_handler.h View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/ui/webui/task_manager_handler.cc View 4 chunks +25 lines, -0 lines 0 comments Download
M chrome/browser/ui/webui/task_manager_ui.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
yoshiki
The previous CL broke the build on win and I created this new CL. Could ...
9 years, 1 month ago (2011-11-10 12:30:51 UTC) #1
mazda
lgtm
9 years, 1 month ago (2011-11-10 12:36:07 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yoshiki@chromium.org/8462009/1
9 years, 1 month ago (2011-11-10 12:40:38 UTC) #3
commit-bot: I haz the power
Try job failure for 8462009-1 (retry) on win_rel for step "chrome_frame_net_tests". It's a second try, ...
9 years, 1 month ago (2011-11-10 14:17:46 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yoshiki@chromium.org/8462009/1
9 years, 1 month ago (2011-11-10 14:31:49 UTC) #5
commit-bot: I haz the power
9 years, 1 month ago (2011-11-10 15:42:21 UTC) #6 
Change committed as 109434

Powered by Google App Engine
This is Rietveld 408576698