Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Issue 8462008: Implement accelerated tee support for POSIX. (Closed)

Created:
9 years, 1 month ago by M-A Ruel
Modified:
9 years, 1 month ago
Reviewers:
Dirk Pranke
CC:
chromium-reviews, Dirk Pranke, M-A Ruel
Visibility:
Public.

Description

Implement accelerated tee support for POSIX. This removes all the need of threading, which removes the contention on the GIL lock. Taking S2Test.test_check_output_tee_large as baseline, numbers are real/user/sys in seconds: Ubuntu workstation: ~25x 2.4/1.9/1.5 -> 0.10/0.70/0.02 OSX 10.6 laptop: ~40x 6.4/5.3/3.9 -> 0.15/0.80/0.07 Cygwin on win7: ~4x 2.8/2.2/1.3 -> 0.60/0.16/0.30 R=dpranke@chromium.org BUG= TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=109283

Patch Set 1 #

Patch Set 2 : Add comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+101 lines, -2 lines) Patch
M subprocess2.py View 1 4 chunks +86 lines, -2 lines 0 comments Download
M tests/subprocess2_test.py View 2 chunks +15 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
M-A Ruel
9 years, 1 month ago (2011-11-04 14:35:03 UTC) #1
Dirk Pranke
lgtm
9 years, 1 month ago (2011-11-09 03:47:35 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/maruel@chromium.org/8462008/3001
9 years, 1 month ago (2011-11-09 19:24:59 UTC) #3
commit-bot: I haz the power
9 years, 1 month ago (2011-11-09 19:30:58 UTC) #4
Change committed as 109283

Powered by Google App Engine
This is Rietveld 408576698