tools/gyp/v8.gyp - Issue 8462006: Override product_extension instead of product_version to set SONAME for Linux shared library

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/gyp/v8.gyp

Issue 8462006: Override product_extension instead of product_version to set SONAME for Linux shared library (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Created 9 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tools/gyp/v8.gyp

diff --git a/tools/gyp/v8.gyp b/tools/gyp/v8.gyp

index b4d074b731df13c9bd94c42f399184d7b3827306..ac836e41af22c31753a2f5509d60771c7596347b 100644

--- a/tools/gyp/v8.gyp

+++ b/tools/gyp/v8.gyp

@@ -72,11 +72,7 @@

}],

['soname_version!=""', {

- # Ideally, we'd like to specify the full filename for the

- # library and set it to "libv8.so.<(soname_version)",

- # but currently the best we can do is use 'product_name' and

- # get "libv8-<(soname_version).so".

- 'product_name': 'v8-<(soname_version)',

+ 'product_extension': 'so.<(soname_version)',

}],

« no previous file with comments | « no previous file | no next file » | no next file with comments »