Exempt chrome-extension:// from third-party cookie rules, but not from regular content settings

chrome/browser/content_settings/cookie_settings.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/content_settings/cookie_settings.h"
 
 #include "base/command_line.h"
 #include "chrome/browser/content_settings/content_settings_utils.h"
 #include "chrome/browser/content_settings/host_content_settings_map.h"
 #include "chrome/browser/prefs/pref_service.h"
 #include "chrome/browser/profiles/profile.h"
 #include "chrome/browser/profiles/profile_dependency_manager.h"
 #include "chrome/browser/profiles/profile_keyed_service.h"
 #include "chrome/common/chrome_notification_types.h"
 #include "chrome/common/chrome_switches.h"
 #include "chrome/common/content_settings_pattern.h"
 #include "chrome/common/pref_names.h"
+#include "chrome/common/url_constants.h"
 #include "content/browser/user_metrics.h"
 #include "content/public/browser/browser_thread.h"
 #include "content/public/browser/notification_service.h"
 #include "content/public/browser/notification_source.h"
 #include "googleurl/src/gurl.h"
 #include "net/base/net_errors.h"
 #include "net/base/static_cookie_policy.h"
 
 using content::BrowserThread;
 
 namespace {
 
 bool IsValidSetting(ContentSetting setting) {
   return (setting == CONTENT_SETTING_ALLOW ||
           setting == CONTENT_SETTING_SESSION_ONLY ||
           setting == CONTENT_SETTING_BLOCK);
 }
 
 bool IsAllowed(ContentSetting setting) {
   DCHECK(IsValidSetting(setting));
   return (setting == CONTENT_SETTING_ALLOW ||
           setting == CONTENT_SETTING_SESSION_ONLY);
 }
 
+// Keep the list of schemes in sync with
+// HostContentSettingsMap::ShouldAllowAllContent.

[Bernhard Bauer, 2011/11/04 10:00:55]

Couldn't we create a single method for this?

[jochen (gone - plz use gerrit), 2011/11/04 10:59:09]

Done.

+bool ShouldAllowAllContent(

[Bernhard Bauer, 2011/11/04 10:00:55]

Nit: I think the first parameter fits on this line?

+    const GURL& url,
+    const GURL& first_party_url) {
+  return url.SchemeIs(chrome::kChromeDevToolsScheme) ||
+         url.SchemeIs(chrome::kChromeInternalScheme) ||
+         url.SchemeIs(chrome::kChromeUIScheme) ||
+         (url.SchemeIs(chrome::kExtensionScheme) &&
+          first_party_url.SchemeIs(chrome::kExtensionScheme));
+}
+
 }  // namespace
 
 // |ProfileKeyedFactory| is the owner of the |ProfileKeyedService|s. This
 // wrapper class allows others to hold shared pointers to CookieSettings.
 class CookieSettingsWrapper : public ProfileKeyedService {
  public:
   explicit CookieSettingsWrapper(scoped_refptr<CookieSettings> cookie_settings)
       : cookie_settings_(cookie_settings) {}
   virtual ~CookieSettingsWrapper() {}
 
@@ skipping 141 matching lines @@
 
 void CookieSettings::ShutdownOnUIThread() {
   DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
   pref_change_registrar_.RemoveAll();
 }
 
 ContentSetting CookieSettings::GetCookieSetting(
     const GURL& url,
     const GURL& first_party_url,
     bool setting_cookie) const {
-  if (HostContentSettingsMap::ShouldAllowAllContent(
-          first_party_url,
-          CONTENT_SETTINGS_TYPE_COOKIES)) {
+  if (ShouldAllowAllContent(url, first_party_url))
     return CONTENT_SETTING_ALLOW;
-  }
 
   ContentSettingsPattern primary_pattern;
   ContentSettingsPattern secondary_pattern;
   // First get any host-specific settings.
   scoped_ptr<base::Value> value(
       host_content_settings_map_->GetContentSettingValue(
           url, first_party_url, CONTENT_SETTINGS_TYPE_COOKIES, "",
           &primary_pattern, &secondary_pattern));
 
   // If no explicit exception has been made and third-party cookies are blocked
   // by default, apply that rule.
   if (primary_pattern == ContentSettingsPattern::Wildcard() &&
       secondary_pattern == ContentSettingsPattern::Wildcard() &&
-      ShouldBlockThirdPartyCookies()) {
+      ShouldBlockThirdPartyCookies() &&
+      !first_party_url.SchemeIs(chrome::kExtensionScheme)) {
     bool strict = CommandLine::ForCurrentProcess()->HasSwitch(
         switches::kBlockReadingThirdPartyCookies);
     net::StaticCookiePolicy policy(strict ?
         net::StaticCookiePolicy::BLOCK_ALL_THIRD_PARTY_COOKIES :
         net::StaticCookiePolicy::BLOCK_SETTING_THIRD_PARTY_COOKIES);
     int rv;
     if (setting_cookie)
       rv = policy.CanSetCookie(url, first_party_url);
     else
       rv = policy.CanGetCookies(url, first_party_url);
@@ skipping 11 matching lines @@
 void CookieSettings::RegisterUserPrefs(PrefService* prefs) {
   prefs->RegisterBooleanPref(prefs::kBlockThirdPartyCookies,
                              false,
                              PrefService::SYNCABLE_PREF);
 }
 
 bool CookieSettings::ShouldBlockThirdPartyCookies() const {
   base::AutoLock auto_lock(lock_);
   return block_third_party_cookies_;
 }