UI polish for certificate viewer.

UI polish for certificate viewer.

Identical to this CL http://codereview.chromium.org/8479042/
Fix base URL problem. All comments about the changes are in the above URL.

This CL makes certificate viewer for chromeos looks like the screen shot posted
in issue 102511. It hacks bubble_frame_view.cc to get rid of the body padding
and add a x button in the title area.

It should not affect the appearance of any other html dialogs.

BUG=102511
TEST=Go to https://www.google.com; Click the locker icon on the left side of URL in the omnibox and click "certificate information". For screenshots, see http://code.google.com/p/chromium/issues/detail?id=102511


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=112717

[bshe, 2011-11-21 16:13:20]

See older comments here
http://codereview.chromium.org/8479042/

[bshe, 2011-11-22 20:33:02]

Hi Rob.

This is the new CL. I have uploaded all the latest changes.

Thanks!

[flackr, 2011-11-22 20:36:36]

LGTM

[commit-bot: I haz the power, 2011-11-23 15:09:13]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/bshe@chromium.org/8461015/3001

[commit-bot: I haz the power, 2011-11-23 15:09:29]

Presubmit check for 8461015-3001 failed and returned exit status 1.

Running presubmit commit checks ...

** Presubmit ERRORS **
Missing LGTM from an OWNER for:
chrome/browser/resources/shared/css/tabs.css,chrome/browser/printing/cloud_print/cloud_print_setup_flow.cc,chrome/browser/resources/sync_internals/sync_index.html,chrome/browser/resources/certificate_viewer.html,chrome/browser/resources/certificate_viewer.css,chrome/browser/printing/print_dialog_cloud.cc,chrome/browser/resources/certificate_viewer.js,chrome/browser/chromeos/status/network_menu.cc,chrome/browser/resources/quota_internals/main.css,chrome/browser/resources/sync_internals/sync_index.css

Presubmit checks took 4.4s to calculate.

[Albert Bodenhamer, 2011-11-23 17:52:16]

lgtm

Just reviewed for changed to cloud print related files.

[commit-bot: I haz the power, 2011-12-01 14:56:03]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/bshe@chromium.org/8461015/24001

[commit-bot: I haz the power, 2011-12-01 14:56:07]

Presubmit check for 8461015-24001 failed and returned exit status 1.

Running presubmit commit checks ...

** Presubmit ERRORS **
Missing LGTM from an OWNER for:
chrome/browser/resources/shared/css/tabs.css,chrome/browser/resources/sync_internals/sync_index.html,chrome/browser/resources/certificate_viewer.html,chrome/browser/resources/certificate_viewer.css,chrome/browser/resources/certificate_viewer.js,chrome/browser/resources/quota_internals/main.css,chrome/browser/resources/sync_internals/sync_index.css

Presubmit checks took 1.4s to calculate.

[bshe, 2011-12-01 15:05:01]

+OWNER for the following file:
chrome/browser/resources/shared/css/tabs.css,
chrome/browser/resources/sync_internals/sync_index.html,
chrome/browser/resources/certificate_viewer.html,
chrome/browser/resources/certificate_viewer.css,
chrome/browser/resources/certificate_viewer.js,
chrome/browser/resources/quota_internals/main.css,
chrome/browser/resources/sync_internals/sync_index.css

Thanks!

[Evan Stade, 2011-12-01 22:09:07]

http://codereview.chromium.org/8461015/diff/24001/chrome/browser/resources/qu...
File chrome/browser/resources/quota_internals/main.css (right):

http://codereview.chromium.org/8461015/diff/24001/chrome/browser/resources/qu...
chrome/browser/resources/quota_internals/main.css:9: margin: 0;
I don't know what quota internals is but I'd have to see a screenshot before I
felt comfortable with this.

http://codereview.chromium.org/8461015/diff/24001/chrome/browser/resources/sh...
File chrome/browser/resources/shared/css/tabs.css (right):

http://codereview.chromium.org/8461015/diff/24001/chrome/browser/resources/sh...
chrome/browser/resources/shared/css/tabs.css:60: padding: 5px 15px 0px 15px;
no px on 0

http://codereview.chromium.org/8461015/diff/24001/chrome/browser/resources/sy...
File chrome/browser/resources/sync_internals/sync_index.css (right):

http://codereview.chromium.org/8461015/diff/24001/chrome/browser/resources/sy...
chrome/browser/resources/sync_internals/sync_index.css:9: margin: 0;
I'm not sure I agree with this change

[bshe, 2011-12-01 22:29:39]

Done.

http://codereview.chromium.org/8461015/diff/24001/chrome/browser/resources/qu...
File chrome/browser/resources/quota_internals/main.css (right):

http://codereview.chromium.org/8461015/diff/24001/chrome/browser/resources/qu...
chrome/browser/resources/quota_internals/main.css:9: margin: 0;
Please see this link: chrome://quota-internals/

On 2011/12/01 22:09:07, Evan Stade wrote:
> I don't know what quota internals is but I'd have to see a screenshot before I
> felt comfortable with this.

http://codereview.chromium.org/8461015/diff/24001/chrome/browser/resources/sh...
File chrome/browser/resources/shared/css/tabs.css (right):

http://codereview.chromium.org/8461015/diff/24001/chrome/browser/resources/sh...
chrome/browser/resources/shared/css/tabs.css:60: padding: 5px 15px 0px 15px;
On 2011/12/01 22:09:07, Evan Stade wrote:
> no px on 0

Done.

http://codereview.chromium.org/8461015/diff/24001/chrome/browser/resources/sy...
File chrome/browser/resources/sync_internals/sync_index.css (right):

http://codereview.chromium.org/8461015/diff/24001/chrome/browser/resources/sy...
chrome/browser/resources/sync_internals/sync_index.css:9: margin: 0;
The reason I made this change is to make the tab box consistent at different
places: chrome://quota-internals/ chrome://sync-internals/ and the certificate
viewer (issue 102511). Glen proposed a UI polish which includes removing the
outer border and padding of tab box for certificate viewer. I cant definitely
make this UI tweak specific to certificate viewer if you prefer it. Please let
me know if you prefer this way. I will delete this file in this case. Thanks!

On 2011/12/01 22:09:07, Evan Stade wrote:
> I'm not sure I agree with this change

[bshe, 2011-12-01 22:55:32]

+ screen shots link
http://code.google.com/p/chromium/issues/detail?id=106113

[Evan Stade, 2011-12-02 00:12:38]

lgtm with body padding restored on sync and quota

[commit-bot: I haz the power, 2011-12-02 14:54:45]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/bshe@chromium.org/8461015/31003

[commit-bot: I haz the power, 2011-12-02 16:48:16]

Change committed as 112717