Chromium Code Reviews| Index: webkit/plugins/webview_plugin.h |
| diff --git a/webkit/plugins/npapi/webview_plugin.h b/webkit/plugins/webview_plugin.h |
| similarity index 96% |
| rename from webkit/plugins/npapi/webview_plugin.h |
| rename to webkit/plugins/webview_plugin.h |
| index c03c8a54c447fbd146bc62c4d391294f179af8fb..201a34f1c971c13a9c0fa52d35a22cfd3e6e787f 100644 |
| --- a/webkit/plugins/npapi/webview_plugin.h |
| +++ b/webkit/plugins/webview_plugin.h |
| @@ -13,7 +13,6 @@ |
| #include "third_party/WebKit/Source/WebKit/chromium/public/WebFrameClient.h" |
| #include "third_party/WebKit/Source/WebKit/chromium/public/WebPlugin.h" |
| #include "third_party/WebKit/Source/WebKit/chromium/public/WebString.h" |
| -#include "third_party/WebKit/Source/WebKit/chromium/public/WebTextDirection.h" |
| #include "third_party/WebKit/Source/WebKit/chromium/public/WebURLResponse.h" |
| #include "third_party/WebKit/Source/WebKit/chromium/public/WebViewClient.h" |
| @@ -23,7 +22,6 @@ class WebMouseEvent; |
| struct WebPreferences; |
| namespace webkit { |
| -namespace npapi { |
| // This class implements the WebPlugin interface by forwarding drawing and |
| // handling input events to a WebView. |
| @@ -47,7 +45,7 @@ class WebViewPlugin: public WebKit::WebPlugin, public WebKit::WebViewClient, |
| virtual void WillDestroyPlugin() = 0; |
| // Called upon a context menu event. |
| - virtual void ShowContextMenu(const WebKit::WebMouseEvent&) = 0; |
| + virtual void ShowContextMenu(const WebKit::WebMouseEvent&) {} |
|
jam
2011/11/22 18:03:32
nit: it's much better to have interfaces that are
Bernhard Bauer
2011/11/22 18:53:33
Hm, I guess that's from an earlier version where I
|
| }; |
| explicit WebViewPlugin(Delegate* delegate); |
| @@ -141,8 +139,11 @@ class WebViewPlugin: public WebKit::WebPlugin, public WebKit::WebViewClient, |
| virtual ~WebViewPlugin(); |
| Delegate* delegate_; |
| + // Destroys itself. |
| WebKit::WebCursorInfo current_cursor_; |
| + // Owns us. |
| WebKit::WebPluginContainer* container_; |
| + // Owned by us, deleted via |close()|. |
| WebKit::WebView* web_view_; |
| gfx::Rect rect_; |
| @@ -153,7 +154,6 @@ class WebViewPlugin: public WebKit::WebPlugin, public WebKit::WebViewClient, |
| WebKit::WebString old_title_; |
| }; |
| -} // namespace npapi |
| } // namespace webkit |
| #endif // WEBKIT_PLUGINS_NPAPI_WEBVIEW_PLUGIN_H_ |