Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(637)

Unified Diff: build/common.gypi

Issue 8461008: Two changes related to the asan=1 mode: (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/common.gypi
===================================================================
--- build/common.gypi (revision 110893)
+++ build/common.gypi (working copy)
@@ -197,8 +197,8 @@
# Has no effect if 'clang' is not set as well.
'clang_use_chrome_plugins%': 0,
- # Enable building with ASAN (Clang's -fasan option).
- # -fasan only works with clang, but asan=1 implies clang=1
+ # Enable building with ASAN (Clang's -faddress-sanitizer option).
+ # -faddress-sanitizer only works with clang, but asan=1 implies clang=1
# See https://sites.google.com/a/chromium.org/dev/developers/testing/addresssanitizer
'asan%': 0,
@@ -1923,12 +1923,17 @@
['asan==1', {
# Only in the linux section for now, since ASAN doesn't
# work on Mac yet.
+ # TODO(glider): -fasan is deprecated. Remove it when we stop using
+ # it.
'cflags': [
'-fasan',
+ '-faddress-sanitizer',
'-w',
+ '-DADDRESS_SANITIZER',
],
'ldflags': [
'-fasan',
+ '-faddress-sanitizer',
],
}],
['no_strict_aliasing==1', {
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698