Space key doesn't work in AURA enabled build because in case of space key,

Space key doesn't work in AURA enabled build because in case of space key,
WebInputEvent::Char event is not sent to WebKit.

TBR=sky@chromium.org
BUG=103753
TEST=Load a html page with a text box and check if space key works.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=109918

[Amruth Raj, 2011-11-04 09:52:16]

Please take a look.

[Ben Goodger (Google), 2011-11-07 17:09:59]

Re-routing to sadrul

[sadrul, 2011-11-07 17:26:46]

Looks like the example in MSDN doc does send CHAR for spaces. So this LGTM.

http://codereview.chromium.org/8461004/diff/1/ui/aura/desktop_host_linux.cc
File ui/aura/desktop_host_linux.cc (right):

http://codereview.chromium.org/8461004/diff/1/ui/aura/desktop_host_linux.cc#n...
ui/aura/desktop_host_linux.cc:218: case ui::VKEY_SPACE:
Move this up above VKEY_TAB.

[Amruth Raj, 2011-11-08 05:47:16]

Please see the new patch with the comment addressed.

http://codereview.chromium.org/8461004/diff/1/ui/aura/desktop_host_linux.cc
File ui/aura/desktop_host_linux.cc (right):

http://codereview.chromium.org/8461004/diff/1/ui/aura/desktop_host_linux.cc#n...
ui/aura/desktop_host_linux.cc:218: case ui::VKEY_SPACE:
On 2011/11/07 17:26:47, sadrul wrote:
> Move this up above VKEY_TAB.

Done.

[Hironori Bono, 2011-11-08 06:00:57]

Greetings,

Thanks for noticing it. Yes, VKEY_SPACE should send a Char event. (I forgot
writing it when reviewing <http://crrev.com/108008>.)

Regards,

Hironori Bono

[Amruth Raj, 2011-11-08 07:20:37]

Also added myself to AUTHORS file

[commit-bot: I haz the power, 2011-11-08 07:35:47]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/ckqr36@motorola.com/8461004/10001

[commit-bot: I haz the power, 2011-11-08 07:35:49]

Presubmit check for 8461004-10001 failed and returned exit status 1.

Running presubmit commit checks ...

** Presubmit ERRORS **
Missing LGTM from an OWNER for: ui/aura/desktop_host_linux.cc

[Amruth Raj, 2011-11-08 16:38:49]

On 2011/11/08 07:35:49, I haz the power (commit-bot) wrote:
> Presubmit check for 8461004-10001 failed and returned exit status 1.
> 
> Running presubmit commit checks ...
> 
> ** Presubmit ERRORS **
> Missing LGTM from an OWNER for: ui/aura/desktop_host_linux.cc
Ben,
Kindly commit this patch.

[Amruth Raj, 2011-11-10 17:51:04]

On 2011/11/08 16:38:49, Amruth Raj wrote:
> On 2011/11/08 07:35:49, I haz the power (commit-bot) wrote:
> > Presubmit check for 8461004-10001 failed and returned exit status 1.
> > 
> > Running presubmit commit checks ...
> > 
> > ** Presubmit ERRORS **
> > Missing LGTM from an OWNER for: ui/aura/desktop_host_linux.cc
> Ben,
> Kindly commit this patch.
Ping.

[Amruth Raj, 2011-11-11 09:44:02]

Updated the bug number in the description.

[sadrul, 2011-11-12 01:44:39]

(needs OWNERS approval)

[sadrul, 2011-11-14 02:27:45]

http://codereview.chromium.org/8461004/diff/10001/AUTHORS
File AUTHORS (right):

http://codereview.chromium.org/8461004/diff/10001/AUTHORS#newcode124
AUTHORS:124: Amruth Raj <ckqr36@motorola.com>
Is this a different Amruth Raj from the one above? If the same person, I will
land without this addition.

[Amruth Raj, 2011-11-14 17:33:07]

On 2011/11/14 02:27:45, sadrul wrote:
> http://codereview.chromium.org/8461004/diff/10001/AUTHORS
> File AUTHORS (right):
> 
> http://codereview.chromium.org/8461004/diff/10001/AUTHORS#newcode124
> AUTHORS:124: Amruth Raj <mailto:ckqr36@motorola.com>
> Is this a different Amruth Raj from the one above? If the same person, I will
> land without this addition.
Its the same Amruth Raj :) however, the this one is an alias to the other. With
the recent upgradation of Google apps, the old one is no longer accepted. Hence
this addition. I believe this one is also required, failing which CQ may post an
error.

[Emmanuel Saint-loubert-Bié, 2011-11-14 18:54:49]

Any chance we could get this in quicly. Whithout the space character it is
really hard to use/test the UI :-)

[sadrul, 2011-11-14 18:57:40]

Indeed. Landed with TBR