Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(259)

Issue 8460012: Add xinput_hierarchy_changed_event_listener.* to 'x11' WATCHLIST (Closed)

Created:
9 years, 1 month ago by Yusuke Sato
Modified:
8 years, 3 months ago
CC:
chromium-reviews, Nirnimesh
Visibility:
Public.

Description

Add xinput_hierarchy_changed_event_listener.* to 'x11' WATCHLIST BUG=None TEST=ran 'python watchlists.py chrome/browser/chromeos/xinput_hierarchy_changed_event_listener.cc' Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=110246

Patch Set 1 : review #

Total comments: 2

Patch Set 2 : review fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M WATCHLISTS View 1 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
Yusuke Sato
sadrul, derat: Can I add xinput_hierarchy_changed_event_listener.{cc,h} to the 'x11' list? The file watches XInput2 events.
9 years, 1 month ago (2011-11-14 08:06:35 UTC) #1
Nirnimesh
http://codereview.chromium.org/8460012/diff/1001/WATCHLISTS File WATCHLISTS (right): http://codereview.chromium.org/8460012/diff/1001/WATCHLISTS#newcode267 WATCHLISTS:267: '|chrome/browser/chromeos/xinput_hierarchy_changed_event_listener\..*' \ 80+ chars. break into 2 lines please
9 years, 1 month ago (2011-11-14 08:16:55 UTC) #2
Yusuke Sato
http://codereview.chromium.org/8460012/diff/1001/WATCHLISTS File WATCHLISTS (right): http://codereview.chromium.org/8460012/diff/1001/WATCHLISTS#newcode267 WATCHLISTS:267: '|chrome/browser/chromeos/xinput_hierarchy_changed_event_listener\..*' \ On 2011/11/14 08:16:55, Nirnimesh wrote: > 80+ ...
9 years, 1 month ago (2011-11-14 16:19:54 UTC) #3
Daniel Erat
lgtm
9 years, 1 month ago (2011-11-14 16:49:10 UTC) #4
Nirnimesh
LGTM
9 years, 1 month ago (2011-11-14 19:40:22 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yusukes@chromium.org/8460012/6001
9 years, 1 month ago (2011-11-16 00:33:04 UTC) #6
commit-bot: I haz the power
Change committed as 110246
9 years, 1 month ago (2011-11-16 04:26:46 UTC) #7
memyy
memyi04@ovi.com
8 years, 3 months ago (2012-09-19 20:41:32 UTC) #8
memyy
memyi04@ovi.cnm
8 years, 3 months ago (2012-09-19 20:52:23 UTC) #9
memyy
2012/9/20, metanata4@gmail.com <metanata4@gmail.com>: > memyi04@ovi.cnm > > https://chromiumcodereview.appspot.com/8460012/ >
8 years, 3 months ago (2012-09-20 01:42:20 UTC) #10
memyy
8 years, 3 months ago (2012-09-20 01:51:40 UTC) #11
very good thuk you.   memyi04@ovi.com

Powered by Google App Engine
This is Rietveld 408576698