Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Issue 8460003: [Mac] Fix a crash on calling ppapi mouse lock when fullscreen has permission (Closed)

Created:
9 years, 1 month ago by jeremya
Modified:
9 years, 1 month ago
Reviewers:
yzshen1
CC:
chromium-reviews
Visibility:
Public.

Description

[Mac] Fix a crash on calling ppapi mouse lock when fullscreen has permission Browser::TogglePresentationMode wasn't setting tab_fullscreen_accepted_ or using GetFullscreenExitBubbleType(), causing a crash when RequestToLockMouse() was called. BUG=102786 TEST=run the ppapi mouse lock example, make the tab fullscreen, click 'Allow', click the plugin. Shouldn't crash. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=108823

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -13 lines) Patch
M chrome/browser/ui/browser.cc View 1 chunk +6 lines, -13 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
jeremya
I'm going to just re-copy-paste from ToggleFullscreenMode in this patch to ease the merge to ...
9 years, 1 month ago (2011-11-04 02:24:53 UTC) #1
yzshen1
LGTM This triggers an assertion, but not a crash in release build, right?
9 years, 1 month ago (2011-11-04 03:57:11 UTC) #2
jeremya
On 2011/11/04 03:57:11, yzshen1 wrote: > LGTM > > This triggers an assertion, but not ...
9 years, 1 month ago (2011-11-04 04:23:40 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jeremya@chromium.org/8460003/1
9 years, 1 month ago (2011-11-04 04:24:00 UTC) #4
commit-bot: I haz the power
Try job failure for 8460003-1 (retry) on win_rel for step "chrome_frame_net_tests". It's a second try, ...
9 years, 1 month ago (2011-11-04 06:17:20 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jeremya@chromium.org/8460003/1
9 years, 1 month ago (2011-11-04 06:41:33 UTC) #6
commit-bot: I haz the power
Try job failure for 8460003-1 (retry) (retry) on win_rel for step "chrome_frame_net_tests". It's a second ...
9 years, 1 month ago (2011-11-04 08:46:04 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jeremya@chromium.org/8460003/1
9 years, 1 month ago (2011-11-06 23:03:54 UTC) #8
commit-bot: I haz the power
9 years, 1 month ago (2011-11-07 00:22:19 UTC) #9
Change committed as 108823

Powered by Google App Engine
This is Rietveld 408576698