Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(501)

Unified Diff: frog/var_member.dart

Issue 8457007: Better runtime type checks. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: merged, and fix typo in member name Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: frog/var_member.dart
diff --git a/frog/var_member.dart b/frog/var_member.dart
index ea09416be8a61a1d25b24b6c4260380c69c3cd60..7bd151e2fd91ee9c01b06e59f828299ae10c1f1c 100644
--- a/frog/var_member.dart
+++ b/frog/var_member.dart
@@ -137,10 +137,13 @@ class VarMethodStub extends VarMember {
// figure out which types can be patched reliably.
// I don't think our other native libs have this issue.
if (member is MethodMember && member.declaringType.library != world.dom) {
+ MethodMember method = member;
+ if (method.needsArgumentConversion(args)) {
+ return false;
+ }
+
// If we have the right number of parameters, or all defaults would be
// filled in as "undefined" anyway, we can just call the method directly.
- MethodMember method = member;
- method.genParameterValues();
for (int i = args.length; i < method.parameters.length; i++) {
if (method.parameters[i].value.code != 'null') {
return false;

Powered by Google App Engine
This is Rietveld 408576698