Better runtime type checks.

frog/member.dart

 // Copyright (c) 2011, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 /** A formal parameter to a [Method]. */
 class Parameter {
   FormalNode definition;
 
   String name;
   Type type;
@@ skipping 671 matching lines @@
       if (p >= 0 && args.values[p].needsTemp) {
         if (lastParameter != null && lastParameter > p) {
           return false;
         }
         lastParameter = p;
       }
     }
     return true;
   }
 
+  /** Returns true if any of the arguments will need conversion. */
+  // TODO(jmesserly): I don't like how this is coupled to invoke

[jimhug, 2011/11/07 16:41:26]

I agree that this is starting to feel nasty - along with the
needsConversion/convertTo coupling.  Let's see if we can clean this up sometime
this week - after a little bit more thought.

+  bool needsArgumentConversion(Arguments args) {
+    int bareCount = args.bareCount;
+    for (int i = 0; i < bareCount; i++) {
+      var arg = args.values[i];
+      if (arg.needsConversion(parameters[i].type)) {
+        return false;
+      }
+    }
+
+    if (bareCount < parameters.length) {
+      genParameterValues();
+      for (int i = bareCount; i < parameters.length; i++) {
+        var arg = args.getValue(parameters[i].name);
+        if (arg != null && arg.needsConversion(parameters[i].type)) {
+          return false;
+        }
+      }
+    }
+
+    return true;
+  }
+
   static String _argCountMsg(int actual, int expected, [bool atLeast=false]) {
     // TODO(jimhug): better messages with default named args.
     return 'wrong number of arguments, expected ' +
         '${atLeast ? "at least " : ""}$expected but found $actual';
   }
 
   Value _argError(MethodGenerator context, Node node, Value target,
       Arguments args, String msg) {
     if (isStatic || isConstructor) {
       world.error(msg, node.span);
@@ skipping 291 matching lines @@
         } else if (name == '\$bit_not') {
           code = '~${target.code}';
         } else if (name == '\$truncdiv') {
           code = '$name(${target.code}, ${argsCode[0]})';
         } else if (name == '\$mod') {
           code = '$name(${target.code}, ${argsCode[0]})';
         } else {
           var op = TokenKind.rawOperatorFromMethod(name);
           code = '${target.code} $op ${argsCode[0]}';
         }
+
         return new Value(returnType, code);
       } else {
         var value;
         num val0, val1, ival0, ival1;
         val0 = target.dynamic.actualValue;
         ival0 = val0.toInt();
         if (args.values.length > 0) {
           val1 = args.values[0].dynamic.actualValue;
           ival1 = val1.toInt();
         }
@@ skipping 431 matching lines @@
   }
 
   void addFactory(String typeName, String name, Member member) {
     getFactoriesFor(typeName)[name] = member;
   }
 
   Member getFactory(String typeName, String name) {
     return getFactoriesFor(typeName)[name];
   }
 
-  void forEach(void f(MethodMember member)) {
+  void forEach(void f(Member member)) {
     factories.forEach((_, Map constructors) {
       constructors.forEach((_, Member member) {
         f(member);
       });
     });
   }
 }