platform_util::OpenItem fixes

chrome/browser/platform_util.h

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_PLATFORM_UTIL_H_
 #define CHROME_BROWSER_PLATFORM_UTIL_H_
 #pragma once
 
 #include <string>
 
 #include "base/string16.h"
 #include "ui/gfx/native_widget_types.h"
 
 class FilePath;
 class GURL;
 
 namespace platform_util {
 
 // Show the given file in a file manager. If possible, select the file.
+// Must be called from the UI thread.

[Mark Mentovai, 2011/11/09 14:22:50]

This doesn’t seem to be true.

It‘s definitely true of the Mac implementation. However, some of the other
implementations allow it to be called from any thread.

Perhaps those implementations could be refactored slightly so that the work that
needs to be done on the file thread is moved to a separate
(anonymous-namespaced?) helper function. Then, ShowItemInFolder and OpenItem can
DCHECK that they’re on the UI thread and post to the file thread; the helpers
can DCHECK that they’re on the file thread and do the work.

That seems substantially cleaner than having some platforms recycle
ShowItemInFolder and OpenItem for different purposes depending on which thread
they’re on, and having them implement different logic for checking thread
correctness and dealing with being called on an unexpected thread.

[achuithb, 2011/11/09 20:21:36]

Done.

 void ShowItemInFolder(const FilePath& full_path);
 
 // Open the given file in the desktop's default manner.
+// Must be called from the UI thread.
 void OpenItem(const FilePath& full_path);
 
 // Open the given external protocol URL in the desktop's default manner.
 // (For example, mailto: URLs in the default mail user agent.)
 void OpenExternal(const GURL& url);
 
 // Get the top level window for the native view. This can return NULL.
 gfx::NativeWindow GetTopLevel(gfx::NativeView view);
 
 // Get the direct parent of |view|, may return NULL.
 gfx::NativeView GetParent(gfx::NativeView view);
 
 // Returns true if |window| is the foreground top level window.
 bool IsWindowActive(gfx::NativeWindow window);
 
 // Activate the window, bringing it to the foreground top level.
 void ActivateWindow(gfx::NativeWindow window);
 
 // Returns true if the view is visible. The exact definition of this is
 // platform-specific, but it is generally not "visible to the user", rather
 // whether the view has the visible attribute set.
 bool IsVisible(gfx::NativeView view);
 
 }  // platform_util
 
 #endif  // CHROME_BROWSER_PLATFORM_UTIL_H_