platform_util::OpenItem fixes

chrome/browser/platform_util_mac.mm

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/platform_util.h"
 
 #include <Carbon/Carbon.h>
 #import <Cocoa/Cocoa.h>
 #include <CoreServices/CoreServices.h>
 
 #include "base/file_path.h"
 #include "base/logging.h"
 #include "base/mac/scoped_aedesc.h"
 #include "base/sys_string_conversions.h"
 #include "googleurl/src/gurl.h"
 #include "grit/generated_resources.h"
 #include "ui/base/l10n/l10n_util.h"
 #include "ui/base/l10n/l10n_util_mac.h"
 
 namespace platform_util {
 
 void ShowItemInFolder(const FilePath& full_path) {
-  DCHECK_EQ([NSThread currentThread], [NSThread mainThread]);
+  DCHECK([NSThread isMainThread]);
   NSString* path_string = base::SysUTF8ToNSString(full_path.value());
   if (!path_string || ![[NSWorkspace sharedWorkspace] selectFile:path_string
                                         inFileViewerRootedAtPath:nil])
     LOG(WARNING) << "NSWorkspace failed to select file " << full_path.value();
 }
 
 // This function opens a file.  This doesn't use LaunchServices or NSWorkspace
 // because of two bugs:
 //  1. Incorrect app activation with com.apple.quarantine:
 //     http://crbug.com/32921
 //  2. Silent no-op for unassociated file types: http://crbug.com/50263
 // Instead, an AppleEvent is constructed to tell the Finder to open the
 // document.
 void OpenItem(const FilePath& full_path) {

[Randy Smith (Not in Mondays), 2011/11/08 22:27:55]

So my interpretation of what I'm reading is that we're now counting on OpenItem
to always be called on the UI thread (some implementations redirect, but this
one doesn't, so the interface restriction is that we always call on the UI
thread).  If that's the case, can we update the commentary in platform_util.h to
say so?

[achuithb, 2011/11/09 00:26:27]

Done.

-  DCHECK_EQ([NSThread currentThread], [NSThread mainThread]);
+  DCHECK([NSThread isMainThread]);
   NSString* path_string = base::SysUTF8ToNSString(full_path.value());
   if (!path_string)
     return;
 
   OSErr status;
 
   // Create the target of this AppleEvent, the Finder.
   base::mac::ScopedAEDesc<AEAddressDesc> address;
   const OSType finderCreatorCode = 'MACS';
   status = AECreateDesc(typeApplSignature,  // type
@@ skipping 65 matching lines @@
                   kAENormalPriority,  // sendPriority
                   kAEDefaultTimeout,  // timeOutInTicks
                   NULL, // idleProc
                   NULL);  // filterProc
   if (status != noErr) {
     LOG(WARNING) << "Could not send AE to Finder in OpenItem()";
   }
 }
 
 void OpenExternal(const GURL& url) {
-  DCHECK_EQ([NSThread currentThread], [NSThread mainThread]);
+  DCHECK([NSThread isMainThread]);
   NSString* url_string = base::SysUTF8ToNSString(url.spec());
   NSURL* ns_url = [NSURL URLWithString:url_string];
   if (!ns_url || ![[NSWorkspace sharedWorkspace] openURL:ns_url])
     LOG(WARNING) << "NSWorkspace failed to open URL " << url;
 }
 
 gfx::NativeWindow GetTopLevel(gfx::NativeView view) {
   return [view window];
 }
 
@@ skipping 11 matching lines @@
 
 bool IsVisible(gfx::NativeView view) {
   // A reasonable approximation of how you'd expect this to behave.
   return (view &&
           ![view isHiddenOrHasHiddenAncestor] &&
           [view window] &&
           [[view window] isVisible]);
 }
 
 }  // namespace platform_util