platform_util::OpenItem fixes

chrome/browser/platform_util_linux.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/platform_util.h"
 
 #include <gtk/gtk.h>
 
+#include "base/bind.h"
 #include "base/file_util.h"
 #include "base/process_util.h"
 #include "base/utf_string_conversions.h"
 #include "content/common/process_watcher.h"
+#include "content/public/browser/browser_thread.h"
 #include "googleurl/src/gurl.h"
 
+using content::BrowserThread;
+
 namespace {
 
 void XDGUtil(const std::string& util, const std::string& arg) {
   std::vector<std::string> argv;
   argv.push_back(util);
   argv.push_back(arg);
 
   base::environment_vector env;
   // xdg-open can fall back on mailcap which eventually might plumb through
   // to a command that needs a terminal.  Set the environment variable telling
@@ skipping 26 matching lines @@
 }
 
 }  // namespace
 
 namespace platform_util {
 
 // TODO(estade): It would be nice to be able to select the file in the file
 // manager, but that probably requires extending xdg-open. For now just
 // show the folder.
 void ShowItemInFolder(const FilePath& full_path) {
+  DCHECK(BrowserThread::CurrentlyOn(BrowserThread::FILE));

[Randy Smith (Not in Mondays), 2011/11/08 22:27:55]

Should we add something into the header file indicating that this function must
be called on the FILE thread?  (I know it always needed to be called, but we
don't currently say so, and this cleanup seems like a good time to fix that.)

Or we could extend the pattern used elsewhere and make it callable on any thread
and do the redirects here.

[achuithb, 2011/11/09 00:26:27]

Done.

   FilePath dir = full_path.DirName();
   if (!file_util::DirectoryExists(dir))
     return;
 
   XDGOpen(dir.value());
 }
 
 void OpenItem(const FilePath& full_path) {
+  if (!BrowserThread::CurrentlyOn(BrowserThread::FILE)) {
+    BrowserThread::PostTask(BrowserThread::FILE, FROM_HERE,
+                            base::Bind(&OpenItem, full_path));
+    return;
+  }
+
+  DCHECK(BrowserThread::CurrentlyOn(BrowserThread::FILE));
   XDGOpen(full_path.value());
 }
 
 void OpenExternal(const GURL& url) {
   if (url.SchemeIs("mailto"))
     XDGEmail(url.spec());
   else
     XDGOpen(url.spec());
 }
 
 }  // namespace platform_util