Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(626)

Issue 8453001: Remove 1 exit time destructor and 1 static initializer from watchdog.cc (Closed)

Created:
9 years, 1 month ago by Nico
Modified:
9 years, 1 month ago
Reviewers:
Mark Mentovai
CC:
chromium-reviews, brettw-cc_chromium.org
Visibility:
Public.

Description

Remove 1 exit time destructor and 1 static initializer from watchdog.cc This file will now leak a lock at exit time. Also move the static data from the .h to the .cc file. BUG=101600, 94925 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=108597

Patch Set 1 #

Total comments: 4

Patch Set 2 : comments & leaky #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -29 lines) Patch
M base/threading/watchdog.h View 1 chunk +0 lines, -12 lines 0 comments Download
M base/threading/watchdog.cc View 1 4 chunks +32 lines, -17 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Nico
9 years, 1 month ago (2011-11-03 21:32:37 UTC) #1
Mark Mentovai
http://codereview.chromium.org/8453001/diff/1/base/threading/watchdog.cc File base/threading/watchdog.cc (right): http://codereview.chromium.org/8453001/diff/1/base/threading/watchdog.cc#newcode22 base/threading/watchdog.cc:22: LazyInstance<Lock> g_static_lock_( // Lock for access of static data... ...
9 years, 1 month ago (2011-11-03 22:11:03 UTC) #2
Nico
All done, also made it leaky.
9 years, 1 month ago (2011-11-03 22:48:29 UTC) #3
Mark Mentovai
LGTM
9 years, 1 month ago (2011-11-03 23:14:22 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thakis@chromium.org/8453001/4001
9 years, 1 month ago (2011-11-03 23:23:48 UTC) #5
commit-bot: I haz the power
9 years, 1 month ago (2011-11-04 00:28:18 UTC) #6
Change committed as 108597

Powered by Google App Engine
This is Rietveld 408576698