Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Issue 8451019: Move download extension api implementation to download/ dir. (Closed)

Created:
9 years, 1 month ago by tfarina
Modified:
9 years, 1 month ago
CC:
chromium-reviews, Erik does not do reviews, mihaip+watch_chromium.org, rdsmith+dwatch_chromium.org, Paweł Hajdan Jr.
Visibility:
Public.

Description

Move download extension api implementation to download/ dir. We're moving all the extension api implementations out of browser/extensions into the directory with the code they are automating. BUG=101244 R=aa@chromium.org,rdsmith@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=108660

Patch Set 1 : #

Total comments: 2

Patch Set 2 : aa review #

Unified diffs Side-by-side diffs Delta from patch set Stats (+110 lines, -982 lines) Patch
A + chrome/browser/download/download_extension_api.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + chrome/browser/download/download_extension_api.cc View 1 16 chunks +101 lines, -47 lines 0 comments Download
A + chrome/browser/download/download_extension_apitest.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
D chrome/browser/extensions/extension_downloads_api.h View 1 chunk +0 lines, -277 lines 0 comments Download
D chrome/browser/extensions/extension_downloads_api.cc View 1 chunk +0 lines, -497 lines 0 comments Download
D chrome/browser/extensions/extension_downloads_api_constants.h View 1 chunk +0 lines, -52 lines 0 comments Download
D chrome/browser/extensions/extension_downloads_api_constants.cc View 1 chunk +0 lines, -65 lines 0 comments Download
D chrome/browser/extensions/extension_downloads_apitest.cc View 1 chunk +0 lines, -33 lines 0 comments Download
M chrome/browser/extensions/extension_function_dispatcher.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/extensions/extension_service.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/chrome_browser.gypi View 1 2 chunks +2 lines, -4 lines 0 comments Download
M chrome/chrome_tests.gypi View 2 chunks +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
tfarina
9 years, 1 month ago (2011-11-04 01:21:50 UTC) #1
Aaron Boodman
Thanks for doing this. See some of the previous CLs I did on the same ...
9 years, 1 month ago (2011-11-04 05:38:12 UTC) #2
tfarina
http://codereview.chromium.org/8451019/diff/2001/chrome/browser/download/download_extension_api_constants.h File chrome/browser/download/download_extension_api_constants.h (right): http://codereview.chromium.org/8451019/diff/2001/chrome/browser/download/download_extension_api_constants.h#newcode5 chrome/browser/download/download_extension_api_constants.h:5: #ifndef CHROME_BROWSER_DOWNLOAD_DOWNLOAD_EXTENSION_API_CONSTANTS_H_ On 2011/11/04 05:38:12, Aaron Boodman wrote: > ...
9 years, 1 month ago (2011-11-04 08:41:03 UTC) #3
Randy Smith (Not in Mondays)
Ben Hayden's the right person to review this for the downloads team; please wait for ...
9 years, 1 month ago (2011-11-04 13:32:32 UTC) #4
benjhayden
LGTM Thank you for doing this! I was just about to split it out of ...
9 years, 1 month ago (2011-11-04 13:45:24 UTC) #5
Aaron Boodman
9 years, 1 month ago (2011-11-04 15:27:14 UTC) #6
lgtm

Powered by Google App Engine
This is Rietveld 408576698