HQP Refactoring (in Preparation for SQLite Cache)

chrome/browser/history/history.h

Index: chrome/browser/history/history.h
===================================================================
--- chrome/browser/history/history.h	(revision 108940)
+++ chrome/browser/history/history.h	(working copy)
@@ -156,8 +156,8 @@
   // TODO(brettw) this should return the InMemoryHistoryBackend.
   history::URLDatabase* InMemoryDatabase();
 
-  // Return the quick history index.
-  history::InMemoryURLIndex* InMemoryIndex();
+  // Returns the history database if it has been set, otherwise NULL.
+  history::URLDatabase* HistoryDatabase();
 
   // Navigation ----------------------------------------------------------------
 
@@ -515,6 +515,11 @@
       CancelableRequestConsumerBase* consumer,
       const GetMostRecentKeywordSearchTermsCallback& callback);
 
+  // InMemoryURLIndex ----------------------------------------------------------
+
+  // Returns the quick history index.
+  history::InMemoryURLIndex* InMemoryIndex() const;

[Peter Kasting, 2011/11/21 19:07:50]

Nit: const mehtods should not return non-const pointers.  Make this method
non-const.

[mrossetti, 2011/11/21 21:53:25]

Done.

+
   // Bookmarks -----------------------------------------------------------------
 
   // Notification that a URL is no longer bookmarked.
@@ -854,6 +859,9 @@
   // on the background thread.
   scoped_ptr<history::InMemoryHistoryBackend> in_memory_backend_;
 
+  // The index used for quick history lookups.
+  scoped_ptr<history::InMemoryURLIndex> in_memory_url_index_;
+
   // The profile, may be null when testing.
   Profile* profile_;