Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(596)

Issue 8447014: Cocoa: Fix clipping issue in search engine protector (Closed)

Created:
9 years, 1 month ago by sail
Modified:
9 years, 1 month ago
Reviewers:
Robert Sesek
CC:
chromium-reviews, Ivan Korotkov
Visibility:
Public.

Description

Cocoa: Fix clipping issue in search engine protector GlobalErrorBubble.xib Changes: Hooked up the new layoutTweaker_ and buttonContainer_ outlet. Made the GTMWidthBasedTweaker slightly wider so that if the bubble was expanded there would be some extra padding on the left side. BUG=100854 TEST=Hard coded some long titles for the accept and cancel buttons. Verified that they were no longer clipped. Hard coded short titles and verified that the buttons looked the same as before. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=110161

Patch Set 1 #

Patch Set 2 : remove debug code #

Total comments: 4

Patch Set 3 : address review comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+78 lines, -18 lines) Patch
M chrome/app/nibs/GlobalErrorBubble.xib View 14 chunks +62 lines, -15 lines 0 comments Download
M chrome/browser/ui/cocoa/global_error_bubble_controller.h View 2 chunks +4 lines, -0 lines 0 comments Download
M chrome/browser/ui/cocoa/global_error_bubble_controller.mm View 1 2 2 chunks +12 lines, -3 lines 0 comments Download

Messages

Total messages: 14 (0 generated)
sail
9 years, 1 month ago (2011-11-03 22:52:11 UTC) #1
Robert Sesek
Please enumerate the XIB changes and fill out the TEST= line. http://codereview.chromium.org/8447014/diff/6/chrome/browser/ui/cocoa/global_error_bubble_controller.mm File chrome/browser/ui/cocoa/global_error_bubble_controller.mm (right): ...
9 years, 1 month ago (2011-11-04 15:35:27 UTC) #2
sail
http://codereview.chromium.org/8447014/diff/6/chrome/browser/ui/cocoa/global_error_bubble_controller.mm File chrome/browser/ui/cocoa/global_error_bubble_controller.mm (right): http://codereview.chromium.org/8447014/diff/6/chrome/browser/ui/cocoa/global_error_bubble_controller.mm#newcode70 chrome/browser/ui/cocoa/global_error_bubble_controller.mm:70: // First make sure that the window is wide ...
9 years, 1 month ago (2011-11-04 20:16:58 UTC) #3
sail
On 2011/11/04 15:35:27, rsesek wrote: > Please enumerate the XIB changes and fill out the ...
9 years, 1 month ago (2011-11-04 20:18:19 UTC) #4
sail
ping!
9 years, 1 month ago (2011-11-08 04:39:11 UTC) #5
sail
ping!
9 years, 1 month ago (2011-11-09 06:00:39 UTC) #6
Robert Sesek
On 2011/11/09 06:00:39, sail wrote: > ping! Sorry for the delay. I checked with tvl ...
9 years, 1 month ago (2011-11-09 16:19:05 UTC) #7
sail
> The best examples were in the old preferences code. > You can take a ...
9 years, 1 month ago (2011-11-14 18:40:54 UTC) #8
Robert Sesek
On 2011/11/14 18:40:54, sail wrote: > > The best examples were in the old preferences ...
9 years, 1 month ago (2011-11-15 16:01:24 UTC) #9
Robert Sesek
http://codereview.chromium.org/8447014/diff/6/chrome/browser/ui/cocoa/global_error_bubble_controller.mm File chrome/browser/ui/cocoa/global_error_bubble_controller.mm (right): http://codereview.chromium.org/8447014/diff/6/chrome/browser/ui/cocoa/global_error_bubble_controller.mm#newcode75 chrome/browser/ui/cocoa/global_error_bubble_controller.mm:75: frame.size.width += NSWidth([buttonContainer_ frame]) - NSWidth(frame); += delta
9 years, 1 month ago (2011-11-15 16:01:28 UTC) #10
sail
http://codereview.chromium.org/8447014/diff/6/chrome/browser/ui/cocoa/global_error_bubble_controller.mm File chrome/browser/ui/cocoa/global_error_bubble_controller.mm (right): http://codereview.chromium.org/8447014/diff/6/chrome/browser/ui/cocoa/global_error_bubble_controller.mm#newcode75 chrome/browser/ui/cocoa/global_error_bubble_controller.mm:75: frame.size.width += NSWidth([buttonContainer_ frame]) - NSWidth(frame); On 2011/11/15 16:01:28, ...
9 years, 1 month ago (2011-11-15 19:12:43 UTC) #11
Robert Sesek
lgtm
9 years, 1 month ago (2011-11-15 19:16:12 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sail@chromium.org/8447014/13001
9 years, 1 month ago (2011-11-15 19:21:20 UTC) #13
commit-bot: I haz the power
9 years, 1 month ago (2011-11-15 20:51:57 UTC) #14
Change committed as 110161

Powered by Google App Engine
This is Rietveld 408576698