Cocoa: Fix clipping issue in search engine protector

Cocoa: Fix clipping issue in search engine protector

GlobalErrorBubble.xib Changes: Hooked up the new layoutTweaker_ and buttonContainer_ outlet. Made the GTMWidthBasedTweaker slightly wider so that if the bubble was expanded there would be some extra padding on the left side.

BUG=100854
TEST=Hard coded some long titles for the accept and cancel buttons. Verified that they were no longer clipped. Hard coded short titles and verified that the buttons looked the same as before.


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=110161

[Robert Sesek, 2011-11-04 15:35:27]

Please enumerate the XIB changes and fill out the TEST= line.

http://codereview.chromium.org/8447014/diff/6/chrome/browser/ui/cocoa/global_...
File chrome/browser/ui/cocoa/global_error_bubble_controller.mm (right):

http://codereview.chromium.org/8447014/diff/6/chrome/browser/ui/cocoa/global_...
chrome/browser/ui/cocoa/global_error_bubble_controller.mm:70: // First make sure
that the window is wide enough to accomidate the buttons.
I think you can do all this within the XIB.

[sail, 2011-11-04 20:16:58]

http://codereview.chromium.org/8447014/diff/6/chrome/browser/ui/cocoa/global_...
File chrome/browser/ui/cocoa/global_error_bubble_controller.mm (right):

http://codereview.chromium.org/8447014/diff/6/chrome/browser/ui/cocoa/global_...
chrome/browser/ui/cocoa/global_error_bubble_controller.mm:70: // First make sure
that the window is wide enough to accomidate the buttons.
On 2011/11/04 15:35:27, rsesek wrote:
> I think you can do all this within the XIB.

I couldn't figure out a way to do this from the XIB since the button strings are
set after the XIB has loaded.

The documentation for -[GTMUILocalizerAndLayoutTweaker tweakUI] says that it's
ok to call it when the value of a UI element is set at runtime.

[sail, 2011-11-04 20:18:19]

On 2011/11/04 15:35:27, rsesek wrote:
> Please enumerate the XIB changes and fill out the TEST= line.

Done.

[sail, 2011-11-08 04:39:11]

ping!

[sail, 2011-11-09 06:00:39]

ping!

[Robert Sesek, 2011-11-09 16:19:05]

On 2011/11/09 06:00:39, sail wrote:
> ping!

Sorry for the delay. I checked with tvl about this and it is possible to do this
without any code changes. The best examples were in the old preferences code.
You can take a look at it here:
http://src.chromium.org/viewvc/chrome?view=rev&revision=77477

[sail, 2011-11-14 18:40:54]

> The best examples were in the old preferences code.
> You can take a look at it here:
> http://src.chromium.org/viewvc/chrome?view=rev&revision=77477

Hi Robert, I've taking a look at a couple of nibs from the old preferences code
and I can't find anything that would help. All the dialogs that I've looked at
do what I'm doing.

For example, ClearBrowsingData.xib is very similar to mine. It has a minimum
size and it loops through the the views trying to find a new preferred size:
http://codereview.chromium.org/6621076/diff/9003/chrome/browser/ui/cocoa/clea...

[Robert Sesek, 2011-11-15 16:01:24]

On 2011/11/14 18:40:54, sail wrote:
> > The best examples were in the old preferences code.
> > You can take a look at it here:
> > http://src.chromium.org/viewvc/chrome?view=rev&revision=77477
> 
> Hi Robert, I've taking a look at a couple of nibs from the old preferences
code
> and I can't find anything that would help. All the dialogs that I've looked at
> do what I'm doing.
> 
> For example, ClearBrowsingData.xib is very similar to mine. It has a minimum
> size and it loops through the the views trying to find a new preferred size:
>
http://codereview.chromium.org/6621076/diff/9003/chrome/browser/ui/cocoa/clea...

Hm. Ok. Tom and I both thought it was possible, but maybe not.

[Robert Sesek, 2011-11-15 16:01:28]

http://codereview.chromium.org/8447014/diff/6/chrome/browser/ui/cocoa/global_...
File chrome/browser/ui/cocoa/global_error_bubble_controller.mm (right):

http://codereview.chromium.org/8447014/diff/6/chrome/browser/ui/cocoa/global_...
chrome/browser/ui/cocoa/global_error_bubble_controller.mm:75: frame.size.width
+= NSWidth([buttonContainer_ frame]) - NSWidth(frame);
+= delta

[sail, 2011-11-15 19:12:43]

http://codereview.chromium.org/8447014/diff/6/chrome/browser/ui/cocoa/global_...
File chrome/browser/ui/cocoa/global_error_bubble_controller.mm (right):

http://codereview.chromium.org/8447014/diff/6/chrome/browser/ui/cocoa/global_...
chrome/browser/ui/cocoa/global_error_bubble_controller.mm:75: frame.size.width
+= NSWidth([buttonContainer_ frame]) - NSWidth(frame);
On 2011/11/15 16:01:28, rsesek wrote:
> += delta

Done.

[Robert Sesek, 2011-11-15 19:16:12]

lgtm

[commit-bot: I haz the power, 2011-11-15 19:21:20]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/sail@chromium.org/8447014/13001

[commit-bot: I haz the power, 2011-11-15 20:51:57]

Change committed as 110161