Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Unified Diff: client/fling/src/java/core/com/google/dart/CompileResult.java

Issue 8447006: Fling: Fix bit rot. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: total Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | client/fling/src/java/core/com/google/dart/CompileService.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: client/fling/src/java/core/com/google/dart/CompileResult.java
diff --git a/client/fling/src/java/core/com/google/dart/CompileResult.java b/client/fling/src/java/core/com/google/dart/CompileResult.java
index 7ce11dbc8e0e2946fec6bb252fab8072631a8531..82d9c2837d97e1b30dedb026c6ee6354244c2729 100644
--- a/client/fling/src/java/core/com/google/dart/CompileResult.java
+++ b/client/fling/src/java/core/com/google/dart/CompileResult.java
@@ -15,27 +15,23 @@ import java.util.List;
@SuppressWarnings("serial")
public class CompileResult implements Serializable {
private final String binary;
- private final List<CompileError> typeErrors;
- private final List<CompileError> fatalErrors;
+ private final List<CompileError> errors;
private final List<CompileError> warnings;
private final Throwable exception;
private final long duration;
- CompileResult(List<CompileError> fatalErrors, List<CompileError> typeErrors, List<CompileError> warnings,
- Throwable exception, long duration) {
+ CompileResult(List<CompileError> errors, List<CompileError> warnings, Throwable exception,
+ long duration) {
this.binary = null;
- this.fatalErrors = fatalErrors;
- this.typeErrors = typeErrors;
+ this.errors = errors;
this.warnings = warnings;
this.exception = exception;
this.duration = duration;
}
- CompileResult(String binary, List<CompileError> fatalErrors, List<CompileError> typeErrors,
- List<CompileError> warnings, long duration) {
+ CompileResult(String binary, List<CompileError> errors, List<CompileError> warnings, long duration) {
this.binary = binary;
- this.typeErrors = typeErrors;
- this.fatalErrors = fatalErrors;
+ this.errors = errors;
this.warnings = warnings;
this.exception = null;
this.duration = duration;
@@ -47,7 +43,7 @@ public class CompileResult implements Serializable {
* Exception that was thrown by the compiler.
*/
public boolean didBuild() {
- return fatalErrors.isEmpty() && exception == null;
+ return errors.isEmpty() && exception == null;
}
/**
@@ -57,12 +53,8 @@ public class CompileResult implements Serializable {
return duration;
}
- public List<CompileError> getFatalErrors() {
- return fatalErrors;
- }
-
- public List<CompileError> getTypeErrors() {
- return typeErrors;
+ public List<CompileError> getErrors() {
+ return errors;
}
public Throwable getException() {
« no previous file with comments | « no previous file | client/fling/src/java/core/com/google/dart/CompileService.java » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698