Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(82)

Issue 8446005: Merge 99109 - Infinite recursion in RenderSVGResourceContainer::markAllClientsForInvalidation (Closed)

Created:
9 years, 1 month ago by leviw_travelin_and_unemployed
Modified:
9 years, 1 month ago
CC:
chromium-reviews
Base URL:
http://svn.webkit.org/repository/webkit/branches/chromium/912/
Visibility:
Public.

Description

Merge 99109 - Infinite recursion in RenderSVGResourceContainer::markAllClientsForInvalidation https://bugs.webkit.org/show_bug.cgi?id=71384 Reviewed by Darin Adler. Source/WebCore: Adding a reentrancy guard to RenderSVGResourceContainer to prevent infinite recursion when resources reference one another and share ids. Test: svg/custom/resource-invalidation-crash.svg * rendering/svg/RenderSVGResourceContainer.cpp: (WebCore::RenderSVGResourceContainer::RenderSVGResourceContainer): (WebCore::RenderSVGResourceContainer::markAllClientsForInvalidation): * rendering/svg/RenderSVGResourceContainer.h: LayoutTests: Fixes a stack overflow when SVG resources reference one another and share ids. * svg/custom/resource-invalidation-crash-expected.png: Added. * svg/custom/resource-invalidation-crash-expected.txt: Added. * svg/custom/resource-invalidation-crash.svg: Added. TBR=leviw@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=99219

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+-3 lines, --3 lines) Patch
A + LayoutTests/svg/custom/resource-invalidation-crash.svg View 0 chunks +-1 lines, --1 lines 0 comments Download
A + LayoutTests/svg/custom/resource-invalidation-crash-expected.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A + LayoutTests/svg/custom/resource-invalidation-crash-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
leviw_travelin_and_unemployed
9 years, 1 month ago (2011-11-03 17:50:16 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698