Issue 8443005: Don't reload into an app process.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8443005: Don't reload into an app process. (Closed)

Created:
9 years, 1 month ago by Charlie Reis

Modified:
9 years, 1 month ago

Reviewers:
jam

CC:
chromium-reviews, Avi (use Gerrit), creis+watch_chromium.org, Erik does not do reviews, Paweł Hajdan Jr., jam, mihaip+watch_chromium.org, dpranke-watch+content_chromium.org, joi+watch-content_chromium.org, Aaron Boodman, darin-cc_chromium.org, brettw-cc_chromium.org, ajwong+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Don't reload into an app process. NavigationEntries are not safe to move from one process to another. BUG=80621, 102408 TEST=Reload a page after installing it as an app. No process swap. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=108571

Patch Set 1 #

Total comments: 2

Patch Set 2 : Merge after revert. #

Created: 9 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -21 lines)			Patch
M	chrome/browser/extensions/app_process_apitest.cc	View	1	2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/renderer/chrome_content_renderer_client.cc	View	1	1 chunk	+0 lines, -9 lines	0 comments	Download
M	content/browser/tab_contents/navigation_entry.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	content/browser/tab_contents/render_view_host_manager.cc	View	1	1 chunk	+3 lines, -9 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Charlie Reis

This CL removes the fix for http://crbug.com/80621 (from http://codereview.chromium.org/7063015/), since it isn't correct to use ...

9 years, 1 month ago (2011-11-03 20:47:58 UTC) #1

lgtm

Expand Messages | Collapse Messages