Revert 108391 - Broke 'compile' on Mac clobber builder

Revert 108391 - Broke 'compile' on Mac clobber builder

Allow javascript unit tests using webui test_api framework.

I moved javascript2webui.js over to chrome/test/base/js2gtest.js and shared it
across webui and unit tests with an extra parameter for test type, which governs
the few differences, such as what to include/subclass from and the flavor of
gtest (TEST_F v. IN_PROC_BROWSER_TEST_F).

v8_unit_test implemented 2 main methods to make it work with the generated C++
- AddLibrary - loads the file in the test context
- RunJavascriptF - launches the runTest with the testFixture and testName,
coordinating with Error and ChromeSend to report results.

Helper functions:
- Error - watches for console.error, noting failure if seen.
- ChromeSend - pulls apart the result from the test_api's call to
chrome.send('testResult', [ok, msg])

R=arv@chromium.org
BUG=87820
TEST=unit_tests --gtest_filter=FrameworkUnitTest.*


Review URL: http://codereview.chromium.org/8418015

TBR=scr@chromium.org
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=108407

[Ryan Sleevi, 2011-11-03 02:53:35]

Possibly something with goma?

http://build.chromium.org/p/chromium/builders/Mac/builds/8695/steps/compile/l...

====Building chrome:unit_tests Support (Release)
____PhaseScriptExecution Rule "js2unit"
    cd /b/build/slave/Mac/build/src/chrome
    /bin/sh -c
"\"/b/build/slave/Mac/build/src/chrome/../xcodebuild/chrome.build/Release/unit_tests
Support.build/Script-7D09BE2C21B36599C0299A45.sh\""
make: *** No rule to make target
`/b/build/slave/Mac/build/src/chrome/../xcodebuild/Release/v8_shell', needed by
`/b/build/slave/Mac/build/src/chrome/../xcodebuild/DerivedSources/Release/js2gtest/chrome/test/data/unit/framework_unittest.cc'.
 Stop.
Command /bin/sh failed with exit code 2
Command /bin/sh failed with exit code 2
====Building chrome:unit_tests (Release)
____Distributed-CompileC
../xcodebuild/chrome.build/Release/unit_tests.build/Objects-normal/i386/framework_unittest.o
    cd /b/build/slave/Mac/build/src/chrome
    setenv DISTCC_HOSTS goma,cpp,lzo
    setenv INCLUDE_SERVER_DIR /tmp/distcc-pump.BGBSQG
    setenv INCLUDE_SERVER_PID 94377
    setenv INCLUDE_SERVER_PORT /tmp/distcc-pump.BGBSQG/socket
    setenv LANG en_US.US-ASCII
    setenv PATH
"/usr/bin:/Developer/usr/bin:/b/build/../depot_tools:/usr/bin:/bin:/usr/sbin:/sbin:/usr/local/bin"
    /b/build/goma/gomacc
/b/build/slave/Mac/build/src/chrome/../third_party/llvm-build/Release+Asserts/bin/clang
-x c++ -arch i386 -fmessage-length=0 -pipe -Wno-trigraphs -fno-exceptions
-fno-rtti -O3 -Werror -Wnewline-eof < SNIP A TON OF PATHS >
-I/b/build/slave/Mac/build/src/chrome/../xcodebuild/DerivedSources/Release/ui/gfx/gl
-I/b/build/slave/Mac/build/src/chrome/../xcodebuild/DerivedSources/Release/ui/ui_resources
-I/b/build/slave/Mac/build/src/chrome/../xcodebuild/DerivedSources/Release/ui/ui_resources_standard
-I../v8/include
-I/b/build/slave/Mac/build/src/chrome/../xcodebuild/DerivedSources/Release/chrome
-I../third_party/ocmock
-I/b/build/slave/Mac/build/src/chrome/../xcodebuild/chrome.build/Release/unit_tests.build/DerivedSources/i386
-I/b/build/slave/Mac/build/src/chrome/../xcodebuild/chrome.build/Release/unit_tests.build/DerivedSources
-fno-strict-aliasing -Xclang -load -Xclang
/b/build/slave/Mac/build/src/tools/clang/scripts/../../../third_party/llvm-build/Release+Asserts/lib/libFindBadConstructs.dylib
-Xclang -add-plugin -Xclang find-bad-constructs -c
/b/build/slave/Mac/build/src/chrome/../xcodebuild/DerivedSources/Release/js2gtest/chrome/test/data/unit/framework_unittest.cc
-o
/b/build/slave/Mac/build/src/chrome/../xcodebuild/chrome.build/Release/unit_tests.build/Objects-normal/i386/framework_unittest.o
clang:error: no such file or directory:
'/b/build/slave/Mac/build/src/chrome/../xcodebuild/DerivedSources/Release/js2gtest/chrome/test/data/unit/framework_unittest.cc'
clang:error: no input files
Command /b/build/goma/gomacc failed with exit code 1
Command /b/build/goma/gomacc failed with exit code 1

[scr, 2011-11-03 03:04:42]

No, I think it's a missing gyp dependency on v8_shell that didn't foil
me or trybots. I'll fix soon.

-SCR

Sent from my iPhone

On Nov 2, 2011, at 7:53 PM, "rsleevi@chromium.org" <rsleevi@chromium.org> wrote:

> Possibly something with goma?
>
>
http://build.chromium.org/p/chromium/builders/Mac/builds/8695/steps/compile/l...
>
> ====Building chrome:unit_tests Support (Release)
> ____PhaseScriptExecution Rule "js2unit"
>    cd /b/build/slave/Mac/build/src/chrome
>    /bin/sh -c
>
"\"/b/build/slave/Mac/build/src/chrome/../xcodebuild/chrome.build/Release/unit_tests
> Support.build/Script-7D09BE2C21B36599C0299A45.sh\""
> make: *** No rule to make target
> `/b/build/slave/Mac/build/src/chrome/../xcodebuild/Release/v8_shell', needed
by
>
`/b/build/slave/Mac/build/src/chrome/../xcodebuild/DerivedSources/Release/js2gtest/chrome/test/data/unit/framework_unittest.cc'.
> Stop.
> Command /bin/sh failed with exit code 2
> Command /bin/sh failed with exit code 2
> ====Building chrome:unit_tests (Release)
> ____Distributed-CompileC
>
../xcodebuild/chrome.build/Release/unit_tests.build/Objects-normal/i386/framework_unittest.o
>    cd /b/build/slave/Mac/build/src/chrome
>    setenv DISTCC_HOSTS goma,cpp,lzo
>    setenv INCLUDE_SERVER_DIR /tmp/distcc-pump.BGBSQG
>    setenv INCLUDE_SERVER_PID 94377
>    setenv INCLUDE_SERVER_PORT /tmp/distcc-pump.BGBSQG/socket
>    setenv LANG en_US.US-ASCII
>    setenv PATH
>
"/usr/bin:/Developer/usr/bin:/b/build/../depot_tools:/usr/bin:/bin:/usr/sbin:/sbin:/usr/local/bin"
>    /b/build/goma/gomacc
>
/b/build/slave/Mac/build/src/chrome/../third_party/llvm-build/Release+Asserts/bin/clang
> -x c++ -arch i386 -fmessage-length=0 -pipe -Wno-trigraphs -fno-exceptions
> -fno-rtti -O3 -Werror -Wnewline-eof < SNIP A TON OF PATHS >
>
-I/b/build/slave/Mac/build/src/chrome/../xcodebuild/DerivedSources/Release/ui/gfx/gl
>
-I/b/build/slave/Mac/build/src/chrome/../xcodebuild/DerivedSources/Release/ui/ui_resources
>
-I/b/build/slave/Mac/build/src/chrome/../xcodebuild/DerivedSources/Release/ui/ui_resources_standard
> -I../v8/include
>
-I/b/build/slave/Mac/build/src/chrome/../xcodebuild/DerivedSources/Release/chrome
> -I../third_party/ocmock
>
-I/b/build/slave/Mac/build/src/chrome/../xcodebuild/chrome.build/Release/unit_tests.build/DerivedSources/i386
>
-I/b/build/slave/Mac/build/src/chrome/../xcodebuild/chrome.build/Release/unit_tests.build/DerivedSources
> -fno-strict-aliasing -Xclang -load -Xclang
>
/b/build/slave/Mac/build/src/tools/clang/scripts/../../../third_party/llvm-build/Release+Asserts/lib/libFindBadConstructs.dylib
> -Xclang -add-plugin -Xclang find-bad-constructs -c
>
/b/build/slave/Mac/build/src/chrome/../xcodebuild/DerivedSources/Release/js2gtest/chrome/test/data/unit/framework_unittest.cc
> -o
>
/b/build/slave/Mac/build/src/chrome/../xcodebuild/chrome.build/Release/unit_tests.build/Objects-normal/i386/framework_unittest.o
> clang:error: no such file or directory:
>
'/b/build/slave/Mac/build/src/chrome/../xcodebuild/DerivedSources/Release/js2gtest/chrome/test/data/unit/framework_unittest.cc'
> clang:error: no input files
> Command /b/build/goma/gomacc failed with exit code 1
> Command /b/build/goma/gomacc failed with exit code 1
>
>
>
> http://codereview.chromium.org/8440060/

[Sheridan Rawlins, 2011-11-03 03:18:31]

LGTM