Intrinsify String.charCodeAt, String.length and String.hashCode. Improves frog performance by 2x.

runtime/vm/intrinsifier_ia32.cc

 // Copyright (c) 2011, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 //
 // The intrinsic code below is executed before a method has built its frame.
 // The return address is on the stack and the arguments below it.
 // Registers EDX (arguments descriptor) and ECX (function) must be preserved.
 // Each intrinsification method returns true if the corresponding
 // Dart method was intrinsified.
 
@@ skipping 57 matching lines @@
   V(ObjectArray, [], Array_getIndexed)                                         \
   V(ObjectArray, []=, Array_setIndexed)                                        \
   V(GrowableObjectArray, get:length, GrowableArray_getLength)                  \
   V(GrowableObjectArray, [], GrowableArray_getIndexed)                         \
   V(ImmutableArray, [], Array_getIndexed)                                      \
   V(ImmutableArray, get:length, Array_getLength)                               \
   V(Math, sqrt, Math_sqrt)                                                     \
   V(Object, ==, Object_equal)                                                  \
   V(FixedSizeArrayIterator, next, FixedSizeArrayIterator_next)                 \
   V(FixedSizeArrayIterator, hasNext, FixedSizeArrayIterator_hasNext)           \
+  V(StringBase, get:length, String_getLength)                                  \
+  V(StringBase, charCodeAt, String_charCodeAt)                                 \
+  V(StringBase, hashCode, String_hashCode)                                     \
 
 #define __ assembler->
 
 static bool ObjectArray_Allocate(Assembler* assembler) {
   // This snippet of inlined code uses the following registers:
   // EAX, EBX, EDI
   // and the newly allocated object is returned in EAX.
   const intptr_t kTypeArgumentsOffset = 2 * kWordSize;
   const intptr_t kArrayLengthOffset = 1 * kWordSize;
   Label fall_through;
@@ skipping 802 matching lines @@
   __ LoadObject(EAX, bool_false);
   __ ret();
   __ Bind(&is_true);
   __ LoadObject(EAX, bool_true);
   __ ret();
   __ Bind(&fall_through);
   return false;
 }
 
 
+static bool String_getLength(Assembler* assembler) {
+  __ movl(EAX, Address(ESP, + 1 * kWordSize));

[siva, 2011/11/02 20:22:06]

// String object.

[srdjan, 2011/11/02 20:31:42]

Done.

+  __ movl(EAX, FieldAddress(EAX, String::length_offset()));
+  __ ret();
+  return true;
+}
+
+
+// TODO(srdjan): Implement for two and four byte strings as well.
+static bool String_charCodeAt(Assembler* assembler) {
+  ObjectStore* object_store = Isolate::Current()->object_store();
+  Label fall_through;
+  __ movl(EBX, Address(ESP, + 1 * kWordSize));  // Index.
+  __ movl(EAX, Address(ESP, + 2 * kWordSize));  // Array.

[siva, 2011/11/02 20:22:06]

// String object. (not Array)

[srdjan, 2011/11/02 20:31:42]

Done.

+  __ testl(EBX, Immediate(kSmiTagMask));
+  __ j(NOT_ZERO, &fall_through, Assembler::kNearJump);  // Non-smi index.
+  // Range check.
+  __ cmpl(EBX, FieldAddress(EAX, String::length_offset()));
+  // Runtime throws exception.
+  __ j(ABOVE_EQUAL, &fall_through, Assembler::kNearJump);
+  __ movl(EDI, FieldAddress(EAX, Instance::class_offset()));
+  __ CompareObject(EDI,
+      Class::ZoneHandle(object_store->one_byte_string_class()));
+  __ j(NOT_EQUAL, &fall_through);
+  __ SmiUntag(EBX);
+  __ movzxb(EAX, FieldAddress(EAX, EBX, TIMES_1, OneByteString::data_offset()));
+  __ SmiTag(EAX);
+  __ ret();
+  __ Bind(&fall_through);
+  return false;
+}
+
+
+static bool String_hashCode(Assembler* assembler) {
+  Label fall_through;
+  __ movl(EAX, Address(ESP, + 1 * kWordSize));

[siva, 2011/11/02 20:22:06]

// String object.

[srdjan, 2011/11/02 20:31:42]

Done.

+  __ movl(EAX, FieldAddress(EAX, String::hash_offset()));
+  __ cmpl(EAX, Immediate(0));
+  __ j(EQUAL, &fall_through, Assembler::kNearJump);

[siva, 2011/11/02 20:22:06]

// Hash not computed yet.

[srdjan, 2011/11/02 20:31:42]

Done.

+  __ ret();
+  __ Bind(&fall_through);
+  return false;
+}
+
 #undef __
 
 
 bool Intrinsifier::Intrinsify(const Function& function, Assembler* assembler) {
   if (!FLAG_intrinsify) return false;
   const char* function_name = String::Handle(function.name()).ToCString();
   const Class& function_class = Class::Handle(function.owner());
   const char* class_name = String::Handle(function_class.Name()).ToCString();
 #define FIND_INTRINSICS(test_class_name, test_function_name, destination)      \
   if ((strcmp(#test_function_name, function_name) == 0) &&                     \
       (strcmp(#test_class_name, class_name) == 0)) {                           \
     return destination(assembler);                                             \
   }                                                                            \
 
 INTRINSIC_LIST(FIND_INTRINSICS);
 #undef FIND_INTRINSICS
   return false;
 }
 
 }  // namespace dart
 
 #endif  // defined TARGET_ARCH_IA32