Issue 8440001: Move Mac's WebDragDest to content.

Issue 8440001: Move Mac's WebDragDest to content. (Closed)

Created:
9 years, 1 month ago by Avi (use Gerrit)

Modified:
9 years, 1 month ago

Reviewers:
Elliot Glaysher, jochen (gone - plz use gerrit)

CC:
chromium-reviews, Avi (use Gerrit), creis+watch_chromium.org, ajwong+watch_chromium.org, jam, dcheng, dpranke-watch+content_chromium.org, joi+watch-content_chromium.org, darin-cc_chromium.org, Paweł Hajdan Jr., brettw-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Move Mac's WebDragDest to content. BUG=95573 TEST=no change in functionality Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=108165

Patch Set 1 #

Total comments: 2

Created: 9 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+25 lines, -500 lines)			Patch
M	chrome/browser/tab_contents/tab_contents_view_mac.h	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/tab_contents/tab_contents_view_mac.mm	View	3 chunks	+2 lines, -2 lines	0 comments	Download
D	chrome/browser/ui/cocoa/tab_contents/web_drop_target.h	View	1 chunk	+0 lines, -80 lines	0 comments	Download
D	chrome/browser/ui/cocoa/tab_contents/web_drop_target.mm	View	1 chunk	+0 lines, -238 lines	0 comments	Download
D	chrome/browser/ui/cocoa/tab_contents/web_drop_target_unittest.mm	View	1 chunk	+0 lines, -156 lines	0 comments	Download
M	chrome/chrome_browser.gypi	View	2 chunks	+0 lines, -4 lines	0 comments	Download
M	chrome/chrome_tests.gypi	View	1 chunk	+0 lines, -1 line	0 comments	Download
A +	content/browser/tab_contents/web_drag_dest_mac.h	View	2 chunks	+2 lines, -2 lines	0 comments	Download
A +	content/browser/tab_contents/web_drag_dest_mac.mm	View	3 chunks	+3 lines, -3 lines	0 comments	Download
A +	content/browser/tab_contents/web_drag_dest_mac_unittest.mm	View	4 chunks	+11 lines, -12 lines	2 comments	Download
M	content/content_browser.gypi	View	2 chunks	+4 lines, -0 lines	0 comments	Download
M	content/content_tests.gypi	View	1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Avi (use Gerrit)

Jochen's out for the day. Elliot? This is just moving stuff around so no ObjC ...

9 years, 1 month ago (2011-11-01 18:33:04 UTC) #2

jochen (gone - plz use gerrit)

lgtm http://codereview.chromium.org/8440001/diff/1/content/browser/tab_contents/web_drag_dest_mac_unittest.mm File content/browser/tab_contents/web_drag_dest_mac_unittest.mm (right): http://codereview.chromium.org/8440001/diff/1/content/browser/tab_contents/web_drag_dest_mac_unittest.mm#newcode47 content/browser/tab_contents/web_drag_dest_mac_unittest.mm:47: scoped_nsobject<WebDragDest> drop_target_; nit rename variable as well?

9 years, 1 month ago (2011-11-01 19:26:03 UTC) #3

Avi (use Gerrit)

9 years, 1 month ago (2011-11-01 20:19:22 UTC) #4

http://codereview.chromium.org/8440001/diff/1/content/browser/tab_contents/we...
File content/browser/tab_contents/web_drag_dest_mac_unittest.mm (right):

http://codereview.chromium.org/8440001/diff/1/content/browser/tab_contents/we...
content/browser/tab_contents/web_drag_dest_mac_unittest.mm:47:
scoped_nsobject<WebDragDest> drop_target_;
On 2011/11/01 19:26:03, jochen wrote:
> nit rename variable as well?

Done.

Expand Messages | Collapse Messages