Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(432)

Unified Diff: runtime/vm/opt_code_generator_ia32.h

Issue 8439059: Restructure instance setter and finish the last 1/3 of increment instance field optimization. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: '' Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | runtime/vm/opt_code_generator_ia32.cc » ('j') | runtime/vm/opt_code_generator_ia32.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/opt_code_generator_ia32.h
===================================================================
--- runtime/vm/opt_code_generator_ia32.h (revision 1129)
+++ runtime/vm/opt_code_generator_ia32.h (working copy)
@@ -68,11 +68,17 @@
void IntrinsifyGetter();
void IntrinsifySetter();
- bool ICDataToSameInlineableInstanceGetter(const ICData& ic_data);
void InlineInstanceGettersWithSameTarget(AstNode* node,
+ intptr_t id,
AstNode* receiver,
const String& field_name,
Register recv_reg);
+ void InlineInstanceSettersWithSameTarget(AstNode* node,
+ intptr_t id,
+ AstNode* receiver,
+ const String& field_name,
+ Register recv_reg,
+ Register value_reg);
// Helper method to load a value quickly into register instead of pushing
// and popping it.
@@ -82,12 +88,17 @@
Register left_reg,
Register right_reg);
- bool IsInlineableInstanceGetter(const Function& function);
void InlineInstanceGetter(AstNode* node,
intptr_t id,
AstNode* receiver,
const String& field_name,
Register recv_reg);
+ void InlineInstanceSetter(AstNode* node,
+ intptr_t id,
+ AstNode* receiver,
+ const String& field_name,
+ Register recv_reg,
+ Register value_reg);
void CallDeoptimize(intptr_t node_id, intptr_t token_index);
@@ -123,7 +134,7 @@
bool IsResultInEaxRequested(AstNode* node) const;
bool NodeMayBeSmi(AstNode* node) const;
- void PrintCollectedClasses(AstNode* node);
+ void PrintCollectedClassesAtId(AstNode* node, intptr_t id);
void TraceOpt(AstNode* node, const char* message);
void TraceNotOpt(AstNode* node, const char* message);
« no previous file with comments | « no previous file | runtime/vm/opt_code_generator_ia32.cc » ('j') | runtime/vm/opt_code_generator_ia32.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698