Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4184)

Unified Diff: bin/process_script.cc

Issue 8439028: Fix return statement to return the right result. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/runtime/
Patch Set: Created 9 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: bin/process_script.cc
===================================================================
--- bin/process_script.cc (revision 1060)
+++ bin/process_script.cc (working copy)
@@ -131,14 +131,14 @@
// url chars.
Dart_Handle source = ReadStringFromFile(url_chars);
if (!Dart_IsValid(source)) {
- return source;
+ return source; // source contains the error string.
}
if (tag == kImportTag) {
Dart_Handle new_lib = Dart_LoadLibrary(url, source);
if (import_builtin_lib && Dart_IsValid(new_lib)) {
Builtin_ImportLibrary(new_lib);
}
- return result;
+ return new_lib; // Return library object or an error string.
} else if (tag == kSourceTag) {
return Dart_LoadSource(library, url, source);
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698