Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(579)

Issue 8439018: Open cros filemanager when "Open Downloads Folder" is clicked. (Closed)

Created:
9 years, 1 month ago by achuithb
Modified:
9 years, 1 month ago
CC:
chromium-reviews, asanka, Randy Smith (Not in Mondays)
Visibility:
Public.

Description

Open cros filemanager when "Open Downloads Folder" is clicked. BUG=chromium-os:21585 TEST=On ChromeOS, ctrl-j for the downloads page, click on Open Downloads Folder to have a new tab open with the filemanager extension positioned in the Downloads folder. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=108374

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -0 lines) Patch
M chrome/browser/ui/webui/downloads_dom_handler.cc View 2 chunks +8 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
achuithb
There is some urgency with this CL as it fixes a Stable-block bug for M15 ...
9 years, 1 month ago (2011-11-01 22:51:28 UTC) #1
benjhayden
LGTM assuming it was tested manually. Please wait for Randy and Asanka.
9 years, 1 month ago (2011-11-02 13:22:51 UTC) #2
Randy Smith (Not in Mondays)
LGTM.
9 years, 1 month ago (2011-11-02 13:25:31 UTC) #3
asanka
Ideally shouldn't this fixed in FileManagerUtil::ViewItem()? Or perhaps in platform_util? That would move platform specific ...
9 years, 1 month ago (2011-11-02 14:14:47 UTC) #4
achuithb
9 years, 1 month ago (2011-11-02 20:45:49 UTC) #5
On 2011/11/02 14:14:47, asanka wrote:
> Ideally shouldn't this fixed in FileManagerUtil::ViewItem()?  Or perhaps in
> platform_util?  That would move platform specific code into the platform
> specific implementations.
> 
> LGTM given the urgency, but long term I think we need to fix
> platform_util::OpenItem() to do the right thing when given a folder.

I'll fix OpenItem for all platforms in a separate CL. I need minimal changes for
M15. 

Thanks for the reviews, Randy, Ben and Asanka!

Powered by Google App Engine
This is Rietveld 408576698