Make infobar controls focusable by default.

views/controls/button/text_button.cc

Index: views/controls/button/text_button.cc
===================================================================
--- views/controls/button/text_button.cc	(revision 107928)
+++ views/controls/button/text_button.cc	(working copy)
@@ -42,6 +42,9 @@
 static const int kPreferredNativeThemePaddingHorizontal = 12;
 static const int kPreferredNativeThemePaddingVertical = 5;
 
+// Number of pixels from the edge of the view to inset the focus rect

[Peter Kasting, 2011/11/01 21:51:28]

Needs to be a complete sentence (I see some existing comments here are wrong). 
But more importantly, why should we inset by 3 px?  Do we randomly add 3 px
outside the text somewhere?  Is this constant the same across different fonts
and languages?  I was hoping to get some insight into the need for this
constant.

+static const int kFocusRectInset = 3;
+
 // Default background color for buttons.
 const SkColor kBackgroundColor = SkColorSetRGB(0xde, 0xde, 0xde);
 
@@ -744,6 +747,14 @@
   return kViewClassName;
 }
 
+void TextButton::OnPaintFocusBorder(gfx::Canvas* canvas) {
+  if ((IsFocusable() || IsAccessibilityFocusableInRootView()) && HasFocus()) {
+    gfx::Rect rect(GetLocalBounds());
+    rect.Inset(kFocusRectInset, kFocusRectInset);
+    canvas->DrawFocusRect(rect);
+  }
+}
+
 gfx::NativeTheme::Part TextButton::GetThemePart() const {
   return gfx::NativeTheme::kPushButton;
 }
@@ -829,7 +840,7 @@
   // that the native text button appears more like a windows button.
   if ((IsFocusable() || IsAccessibilityFocusableInRootView()) && HasFocus()) {
     gfx::Rect rect(GetLocalBounds());
-    rect.Inset(3, 3);
+    rect.Inset(kFocusRectInset, kFocusRectInset);
     canvas->DrawFocusRect(rect);
   }
 #else