Make infobar controls focusable by default.

Make infobar controls focusable by default.

This also fixes views::TextButton so that the focus rect is drawn
with an appropriate inset.

BUG=98367
TEST=Trigger an infobar (Translate, Save Password, etc.), type Ctrl+L to focus location bar, press Tab to focus controls in info bar.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=108202

[Peter Kasting, 2011-11-01 21:46:04]

http://codereview.chromium.org/8439015/diff/1/views/controls/button/text_butt...
File views/controls/button/text_button.cc (right):

http://codereview.chromium.org/8439015/diff/1/views/controls/button/text_butt...
views/controls/button/text_button.cc:750: rect.Inset(3, 3);
Please, no context-free magic numbers.

[dmazzoni, 2011-11-01 21:49:06]

http://codereview.chromium.org/8439015/diff/1/views/controls/button/text_butt...
File views/controls/button/text_button.cc (right):

http://codereview.chromium.org/8439015/diff/1/views/controls/button/text_butt...
views/controls/button/text_button.cc:750: rect.Inset(3, 3);
On 2011/11/01 21:46:04, Peter Kasting wrote:
> Please, no context-free magic numbers.

Updated to use a constant instead.

[Peter Kasting, 2011-11-01 21:51:28]

http://codereview.chromium.org/8439015/diff/6001/views/controls/button/text_b...
File views/controls/button/text_button.cc (right):

http://codereview.chromium.org/8439015/diff/6001/views/controls/button/text_b...
views/controls/button/text_button.cc:45: // Number of pixels from the edge of
the view to inset the focus rect
Needs to be a complete sentence (I see some existing comments here are wrong). 
But more importantly, why should we inset by 3 px?  Do we randomly add 3 px
outside the text somewhere?  Is this constant the same across different fonts
and languages?  I was hoping to get some insight into the need for this
constant.

[dmazzoni, 2011-11-01 22:25:57]

On 2011/11/01 21:51:28, Peter Kasting wrote:
> views/controls/button/text_button.cc:45: // Number of pixels from the edge of
> the view to inset the focus rect
> Needs to be a complete sentence (I see some existing comments here are wrong).

> But more importantly, why should we inset by 3 px?  Do we randomly add 3 px
> outside the text somewhere?  Is this constant the same across different fonts
> and languages?  I was hoping to get some insight into the need for this
> constant.

Take another look, I hope that helps.

[Peter Kasting, 2011-11-01 22:30:05]

Fantastic, thanks.  LGTM.

[sky, 2011-11-01 23:03:26]

LGTM

[commit-bot: I haz the power, 2011-11-01 23:23:53]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/dmazzoni@chromium.org/8439015/1008

[commit-bot: I haz the power, 2011-11-02 00:24:43]

Change committed as 108202