Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(133)

Issue 8438070: libevent: fix include style (Closed)

Created:
9 years, 1 month ago by ensonic
Modified:
9 years, 1 month ago
Reviewers:
M-A Ruel
CC:
chromium-reviews
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

libevent: fix include style We always want to include the local headers instead of eventually installed ones. Removes the workaround from the gyp build file as that is the wrong and unsafe fix. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=109251

Patch Set 1 #

Patch Set 2 : libevent: fix include style #

Total comments: 2

Patch Set 3 : libevent: fix include style #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -6 lines) Patch
M third_party/libevent/chromium.patch View 1 2 1 chunk +13 lines, -0 lines 0 comments Download
M third_party/libevent/evdns.c View 1 chunk +1 line, -1 line 0 comments Download
M third_party/libevent/evhttp.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/libevent/libevent.gyp View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
ensonic
9 years, 1 month ago (2011-11-03 10:19:32 UTC) #1
M-A Ruel
If you modify libevent, you need to update chromium.patch at the same time.
9 years, 1 month ago (2011-11-07 16:37:44 UTC) #2
ensonic
On 2011/11/07 16:37:44, Marc-Antoine Ruel wrote: > If you modify libevent, you need to update ...
9 years, 1 month ago (2011-11-07 17:01:04 UTC) #3
M-A Ruel
http://codereview.chromium.org/8438070/diff/3001/third_party/libevent/chromium.patch File third_party/libevent/chromium.patch (right): http://codereview.chromium.org/8438070/diff/3001/third_party/libevent/chromium.patch#newcode56 third_party/libevent/chromium.patch:56: Oops, it's an error in the presubmit check. :/ ...
9 years, 1 month ago (2011-11-07 17:49:49 UTC) #4
M-A Ruel
http://codereview.chromium.org/8438070/diff/3001/third_party/libevent/chromium.patch File third_party/libevent/chromium.patch (right): http://codereview.chromium.org/8438070/diff/3001/third_party/libevent/chromium.patch#newcode56 third_party/libevent/chromium.patch:56: On 2011/11/07 17:49:50, Marc-Antoine Ruel wrote: > Oops, it's ...
9 years, 1 month ago (2011-11-08 16:39:31 UTC) #5
ensonic
On 2011/11/08 16:39:31, Marc-Antoine Ruel wrote: > http://codereview.chromium.org/8438070/diff/3001/third_party/libevent/chromium.patch > File third_party/libevent/chromium.patch (right): > > http://codereview.chromium.org/8438070/diff/3001/third_party/libevent/chromium.patch#newcode56 ...
9 years, 1 month ago (2011-11-09 09:50:49 UTC) #6
M-A Ruel
lgtm
9 years, 1 month ago (2011-11-09 14:16:31 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ensonic@google.com/8438070/7001
9 years, 1 month ago (2011-11-09 14:16:41 UTC) #8
commit-bot: I haz the power
9 years, 1 month ago (2011-11-09 16:00:29 UTC) #9
Change committed as 109251

Powered by Google App Engine
This is Rietveld 408576698