Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(74)

Unified Diff: chrome/renderer/print_web_view_helper.cc

Issue 8438061: Merge 106160 - Fix print media page size by using the value we compute. (Closed) Base URL: svn://svn.chromium.org/chrome/branches/874/src/
Patch Set: Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/renderer/print_web_view_helper.cc
===================================================================
--- chrome/renderer/print_web_view_helper.cc (revision 108392)
+++ chrome/renderer/print_web_view_helper.cc (working copy)
@@ -1396,8 +1396,6 @@
DCHECK(IsReadyToRender());
state_ = RENDERING;
- print_params_.reset(new PrintMsg_Print_Params(*print_params));
-
metafile_.reset(new printing::PreviewMetafile);
if (!metafile_->Init()) {
LOG(ERROR) << "PreviewMetafile Init failed";
@@ -1410,6 +1408,8 @@
UpdatePrintableSizeInPrintParameters(frame_, node_.get(),
prep_frame_view_.get(), print_params);
+ print_params_.reset(new PrintMsg_Print_Params(*print_params));
+
total_page_count_ = prep_frame_view_->GetExpectedPageCount();
if (total_page_count_ == 0) {
LOG(ERROR) << "CreatePreviewDocument got 0 page count";
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698