Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4221)

Unified Diff: chrome/browser/ui/views/bookmarks/bookmark_editor_view_unittest.cc

Issue 8438037: Change 'Add Page' to show a simple input dialog with --use-more-webui. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: Address comments Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/bookmarks/bookmark_editor_view_unittest.cc
diff --git a/chrome/browser/ui/views/bookmarks/bookmark_editor_view_unittest.cc b/chrome/browser/ui/views/bookmarks/bookmark_editor_view_unittest.cc
index 6907a8b8b04cf76a34413218c8191458cf87dce7..37f9aa1b01e18f8c3c89875a8f09207ea2b6a997 100644
--- a/chrome/browser/ui/views/bookmarks/bookmark_editor_view_unittest.cc
+++ b/chrome/browser/ui/views/bookmarks/bookmark_editor_view_unittest.cc
@@ -132,7 +132,7 @@ class BookmarkEditorViewTest : public testing::Test {
// Makes sure the tree model matches that of the bookmark bar model.
TEST_F(BookmarkEditorViewTest, ModelsMatch) {
CreateEditor(profile_.get(), NULL,
- BookmarkEditor::EditDetails::AddNodeInFolder(NULL),
+ BookmarkEditor::EditDetails::AddNodeInFolder(NULL, -1),
BookmarkEditorView::SHOW_TREE);
BookmarkEditorView::EditorNode* editor_root = editor_tree_model()->GetRoot();
// The root should have two or three children: bookmark bar, other bookmarks
@@ -263,7 +263,7 @@ TEST_F(BookmarkEditorViewTest, MoveToNewParent) {
// Brings up the editor, creating a new URL on the bookmark bar.
TEST_F(BookmarkEditorViewTest, NewURL) {
CreateEditor(profile_.get(), NULL,
- BookmarkEditor::EditDetails::AddNodeInFolder(NULL),
+ BookmarkEditor::EditDetails::AddNodeInFolder(NULL, -1),
BookmarkEditorView::SHOW_TREE);
SetURLText(UTF8ToWide(GURL(base_path() + "a").spec()));
@@ -325,7 +325,7 @@ TEST_F(BookmarkEditorViewTest, ChangeTitleNoTree) {
TEST_F(BookmarkEditorViewTest, NewFolder) {
const BookmarkNode* bb_node = model_->bookmark_bar_node();
BookmarkEditor::EditDetails details =
- BookmarkEditor::EditDetails::AddFolder(bb_node);
+ BookmarkEditor::EditDetails::AddFolder(bb_node, -1);
details.urls.push_back(std::make_pair(GURL(base_path() + "x"),
ASCIIToUTF16("z")));
CreateEditor(profile_.get(), bb_node, details, BookmarkEditorView::SHOW_TREE);
@@ -354,7 +354,7 @@ TEST_F(BookmarkEditorViewTest, NewFolder) {
// in then the editor is initially created showing.
TEST_F(BookmarkEditorViewTest, MoveFolder) {
BookmarkEditor::EditDetails details = BookmarkEditor::EditDetails::AddFolder(
- model_->bookmark_bar_node());
+ model_->bookmark_bar_node(), -1);
details.urls.push_back(std::make_pair(GURL(base_path() + "x"),
ASCIIToUTF16("z")));
CreateEditor(profile_.get(), model_->bookmark_bar_node(),

Powered by Google App Engine
This is Rietveld 408576698