Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(694)

Unified Diff: chrome/browser/bookmarks/bookmark_context_menu_controller.cc

Issue 8438037: Change 'Add Page' to show a simple input dialog with --use-more-webui. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: Address comments Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/bookmarks/bookmark_editor.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/bookmarks/bookmark_context_menu_controller.cc
diff --git a/chrome/browser/bookmarks/bookmark_context_menu_controller.cc b/chrome/browser/bookmarks/bookmark_context_menu_controller.cc
index 6d31d4014788a857389cd03c24a83eed8ec7e1ba..a7fdbe74ab0579bf19edfa40e60c8eefdf416796 100644
--- a/chrome/browser/bookmarks/bookmark_context_menu_controller.cc
+++ b/chrome/browser/bookmarks/bookmark_context_menu_controller.cc
@@ -7,7 +7,6 @@
#include "base/compiler_specific.h"
#include "chrome/app/chrome_command_ids.h"
#include "chrome/browser/bookmarks/bookmark_editor.h"
-#include "chrome/browser/bookmarks/bookmark_folder_editor_controller.h"
#include "chrome/browser/bookmarks/bookmark_model.h"
#include "chrome/browser/bookmarks/bookmark_utils.h"
#include "chrome/browser/prefs/incognito_mode_prefs.h"
@@ -138,15 +137,11 @@ void BookmarkContextMenuController::ExecuteCommand(int id) {
break;
}
- if (selection_[0]->is_url()) {
- BookmarkEditor::Show(parent_window_, profile_,
- BookmarkEditor::EditDetails::EditNode(selection_[0]),
- BookmarkEditor::SHOW_TREE);
- } else {
- BookmarkFolderEditorController::Show(profile_, parent_window_,
- selection_[0], -1,
- BookmarkFolderEditorController::EXISTING_BOOKMARK);
- }
+ BookmarkEditor::Show(
+ parent_window_,
+ profile_,
+ BookmarkEditor::EditDetails::EditNode(selection_[0]),
+ BookmarkEditor::SHOW_TREE);
break;
case IDC_BOOKMARK_BAR_REMOVE: {
@@ -166,11 +161,13 @@ void BookmarkContextMenuController::ExecuteCommand(int id) {
UserMetrics::RecordAction(
UserMetricsAction("BookmarkBar_ContextMenu_Add"));
- // TODO: this should honor the index from GetParentForNewNodes.
+ int index;
+ const BookmarkNode* parent =
+ bookmark_utils::GetParentForNewNodes(parent_, selection_, &index);
BookmarkEditor::Show(
- parent_window_, profile_,
- BookmarkEditor::EditDetails::AddNodeInFolder(
- bookmark_utils::GetParentForNewNodes(parent_, selection_, NULL)),
+ parent_window_,
+ profile_,
+ BookmarkEditor::EditDetails::AddNodeInFolder(parent, index),
BookmarkEditor::SHOW_TREE);
break;
}
@@ -178,11 +175,15 @@ void BookmarkContextMenuController::ExecuteCommand(int id) {
case IDC_BOOKMARK_BAR_NEW_FOLDER: {
UserMetrics::RecordAction(
UserMetricsAction("BookmarkBar_ContextMenu_NewFolder"));
+
int index;
const BookmarkNode* parent =
bookmark_utils::GetParentForNewNodes(parent_, selection_, &index);
- BookmarkFolderEditorController::Show(profile_, parent_window_, parent,
- index, BookmarkFolderEditorController::NEW_BOOKMARK);
+ BookmarkEditor::Show(
+ parent_window_,
+ profile_,
+ BookmarkEditor::EditDetails::AddFolder(parent, index),
+ BookmarkEditor::SHOW_TREE);
break;
}
« no previous file with comments | « no previous file | chrome/browser/bookmarks/bookmark_editor.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698